Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated Loki Otlp Ingest Configuration #12648

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

Jayclifford345
Copy link
Contributor

I have added some minor updates to the documentation based on my initial walkthrough.

  • Provided users with the unstructured metadata flag
  • Updated Loki Address (included port)
  • Added nesting for otlp_config

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes NA

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

I have added some minor updates to the documentation based on my initial walkthrough.

* Provided users with the unstructured metadata flag
* Updated Loki Address (included port)
* Added nesting for otlp_config
@Jayclifford345 Jayclifford345 requested a review from a team as a code owner April 17, 2024 08:14
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 17, 2024
@Jayclifford345 Jayclifford345 changed the title Minor Fix: Updated Loki Otlp Ingest Configuration fix: Updated Loki Otlp Ingest Configuration Apr 17, 2024
@Jayclifford345
Copy link
Contributor Author

Hey @JStickler, I had a stab at updating the doc we discussed yesterday. I am unsure what to do about this doc-validator test. Do I also need to update the template in someway?

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure what to do about this doc-validator test.

Oh, I have a fix for that, but haven't had a chance to get it implemented yet. Let me get it into a PR and get that merged. Then you can just rebase to pull in the fix and then this should pass doc-validator.

docs/sources/send-data/otel/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler merged commit ff88f3c into main Apr 18, 2024
13 checks passed
@JStickler JStickler deleted the Jayclifford345-otel-ingest-configuration-update branch April 18, 2024 12:55
grafanabot pushed a commit that referenced this pull request Apr 18, 2024
Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit ff88f3c)
@Jayclifford345
Copy link
Contributor Author

Woohoo! Thanks @JStickler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants