Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nix): lambda-promtail vendor hash #12763

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Fixes the vendor hash for lamda-promtail, looks like the deps have been updated.

@trevorwhitney trevorwhitney requested a review from a team as a code owner April 23, 2024 16:48
@@ -63,7 +63,7 @@ func (p *processor) runWithBounds(ctx context.Context, tasks []Task, bounds v1.M
return nil
}

func (p *processor) processTasks(ctx context.Context, tenant string, day config.DayTime, keyspaces v1.MultiFingerprintBounds, tasks []Task) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a change here was intended?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, the linter fails on the unused parameter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, I missed that this was also failing the same Nix linting job

how was it not failing any other linting jobs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't quite got to the bottom of that, but it has something to do with how we only lint on changes (vs nix build linting on everything because there's not concept of version control in the nix build). however, that means these changes do sneak through somehow, and that's the part I haven't figured out. something small like this pops up on almost every small nix PR like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, I still would have assumed the regular golangci-lint job would have failed on the PR that originally added this LOC

@trevorwhitney trevorwhitney merged commit ae180d6 into main Apr 23, 2024
60 checks passed
@trevorwhitney trevorwhitney deleted the nix-fix-lambda-promtail branch April 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants