fix(aggregated-metrics): correctly create logfmt string #14124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
commented
Sep 12, 2024
Comment on lines
-246
to
-249
| func humanizeBytes(val uint64) string { | ||
| return strings.Replace(humanize.Bytes(val), " ", "", 1) | ||
| } | ||
|
|
There was a problem hiding this comment.
Basically just moved this to utils.HumanizeBytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The aggregated metrics added in #13731 currently create the entry to be logged in logfmt format. This PR correctly adds quotes to strings being added, and adds a util function to humanize bytes without whitespaces. Basically it moves the implementation from
metrics.gotometrics_helper.go.Aggregated metrics entries currently look like:
Especially notice the
107 Bwhich breaks the "correct" logfmt format.With this PR the entry will look like: