Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert "feat: add functions to common.libsonnet for warpstream" #14129

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Sep 12, 2024

Reverts #14123. We won't be using these.

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner September 12, 2024 13:32
@grobinson-grafana grobinson-grafana changed the title Revert "feat: add functions to common.libsonnet for warpstream" chore: Revert "feat: add functions to common.libsonnet for warpstream" Sep 12, 2024
@grobinson-grafana grobinson-grafana changed the title chore: Revert "feat: add functions to common.libsonnet for warpstream" chore: revert "feat: add functions to common.libsonnet for warpstream" Sep 12, 2024
@grobinson-grafana grobinson-grafana changed the title chore: revert "feat: add functions to common.libsonnet for warpstream" task: revert "feat: add functions to common.libsonnet for warpstream" Sep 12, 2024
@grobinson-grafana grobinson-grafana changed the title task: revert "feat: add functions to common.libsonnet for warpstream" feat: revert "feat: add functions to common.libsonnet for warpstream" Sep 12, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana merged commit 18c27f9 into main Sep 12, 2024
61 of 62 checks passed
@grobinson-grafana grobinson-grafana deleted the revert-14123-grobinson/update-common-libsonnet-warpstream branch September 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants