Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query-schedulers returns error which can't be parsed by query-frontend, resulting in 5xx #2624

Closed
replay opened this issue Aug 1, 2022 · 1 comment

Comments

@replay
Copy link
Contributor

replay commented Aug 1, 2022

Describe the bug

The error which gets returned when the query scheduler has too many outstanding requests is a simple string, here:

HttpResponse: &httpgrpc.HTTPResponse{
Code: http.StatusTooManyRequests,
Body: []byte("too many outstanding requests"),
},

When the query-frontend receives that error it tries to unmarshal it as JSON, which doesn't work, here:

if err := json.Unmarshal(buf, &resp); err != nil {

This results in a 5xx error and log message like this one:

image

@replay
Copy link
Contributor Author

replay commented Aug 1, 2022

This is duplicate with #2447

@replay replay closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant