You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In pkg/mimir/ we do an extensive use of Config.isAnyModuleEnabled(). This function checks if any of the input modules have been specified in the -target CLI flag or YAML config parameter. This means that if we want to check if the distributor is running, we have to specify all targets that would run the distributor, like Distributor, All, Write.
Having to specify every possible target that would run a given module is very error prone. We should instead resolve the dependency tree and have a function which just takes in input the module we want to check, and then it's checked against all modules that will be running based on the resolve dependency tree (e.g. if you want to check if the distributor is running, just check for Distributor).
The text was updated successfully, but these errors were encountered:
In
pkg/mimir/
we do an extensive use ofConfig.isAnyModuleEnabled()
. This function checks if any of the input modules have been specified in the-target
CLI flag or YAML config parameter. This means that if we want to check if the distributor is running, we have to specify all targets that would run the distributor, likeDistributor, All, Write
.Having to specify every possible target that would run a given module is very error prone. We should instead resolve the dependency tree and have a function which just takes in input the module we want to check, and then it's checked against all modules that will be running based on the resolve dependency tree (e.g. if you want to check if the distributor is running, just check for
Distributor
).The text was updated successfully, but these errors were encountered: