Support multi-tenancy in TempoMonolithic CR #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
from
861bc61 to
3f1a6d0
Compare
andreasgerstmayr
changed the title
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
from
3f1a6d0 to
1e694d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
+ Coverage 74.26% 75.25% +0.99%
==========================================
Files 89 90 +1
Lines 6587 6932 +345
==========================================
+ Hits 4892 5217 +325
- Misses 1453 1463 +10
- Partials 242 252 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
3 times, most recently
from
788050c to
cc26d4f
Compare
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
from
cc26d4f to
959dded
Compare
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
7 times, most recently
from
289fb57 to
da40700
Compare
andreasgerstmayr
changed the title
andreasgerstmayr
changed the title
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
3 times, most recently
from
1fdddba to
1767cad
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
from
1767cad to
7b67fa9
Compare
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
from
d2fc200 to
e0dcbe6
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
monolithic-multitenancy
branch
from
e0dcbe6 to
590ca4e
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
rubenvp8510
reviewed
Mar 15, 2024
| // The internal server is required because if the gateway is enabled, | ||
| // the Tempo API will listen on localhost only, | ||
| // and then Kubernetes cannot reach the health check endpoint. | ||
| config.InternalServer.Enable = true |
There was a problem hiding this comment.
Wondering if we cannot have the internal server always enabled? :D
There was a problem hiding this comment.
Yes, I think we should always enable it in the TempoStack as well.
It is always enabled in TempoMonolithic.
rubenvp8510
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multi-tenancy in TempoMonolithic CR.