Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create features section in Tempo config #1287

Open
yvrhdn opened this issue Feb 15, 2022 · 3 comments
Open

Create features section in Tempo config #1287

yvrhdn opened this issue Feb 15, 2022 · 3 comments
Labels
keepalive Label to exempt Issues / PRs from stale workflow

Comments

@yvrhdn
Copy link
Member

yvrhdn commented Feb 15, 2022

Is your feature request related to a problem? Please describe.
Tempo is gradually gaining optional features/components that can be enabled/disabled globally. We already have search_enabled and #1282 adds metrics_generator_enabled.

These toggles control major features usually impacting multiple components.

Describe the solution you'd like
To make it easier to find these toggles we can group them in a global section features, i.e.:

features:
  multitenancy_enabled: true
  search_enabled: true
  metrics_generator_enabled: false

Describe alternatives you've considered
We can just not do this and keep the status quo:

multitenancy_enabled: true
search_enabled: true
distributor:
  metrics_generator_enabled: true
  # ...

Or move them all to the top-level:

multitenancy_enabled: true
search_enabled: true
metrics_generator_enabled: true

This is probably fine for now but might become impractical if we add many toggles 🤷🏻

Additional context

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Nov 16, 2022
@electron0zero electron0zero added keepalive Label to exempt Issues / PRs from stale workflow and removed stale Used for stale issues / PRs labels Nov 16, 2022
@ishanjain28
Copy link
Contributor

Hi @kvrhdn, It looks like this issue is stale now.
search_enabled, metrics_generator_enabled flags were removed from tempo a while back.

Only multitenancy_enabled is left and it's a top level flag already

@yvrhdn
Copy link
Member Author

yvrhdn commented Jun 26, 2024

Yeah, features come and go. Search and metrics-generator are now enabled by default, we had another temporary flag autocomplete_filtering_enabled that very recently got removed.
I think the original request of putting these flags in a features section is still fine though, we just don't really care enough about it to do the breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Label to exempt Issues / PRs from stale workflow
Projects
None yet
Development

No branches or pull requests

3 participants