Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo Query Frontend Refactor #3413

Closed
7 of 9 tasks
joe-elliott opened this issue Feb 20, 2024 · 3 comments · Fixed by #3584
Closed
7 of 9 tasks

Tempo Query Frontend Refactor #3413

joe-elliott opened this issue Feb 20, 2024 · 3 comments · Fixed by #3584
Assignees

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Feb 20, 2024

The query frontend code has been pushed to its absolute limits. We need a refactor for improved code clarity, performance, enable streaming on all endpoints and pave the way for more advanced features demanded by TraceQL metrics.

The first PR has been opened and will address the first two tasks when merged: #3400

Tasks

  • Build tools to construct asynchronous pipelines
  • Migrate search to the new pipelines
  • Migrate tag endpoints to the new pipelines
  • Migrate trace id endpoints to the new pipelines. (remain synchronous but use new patterns)
  • Migrate metrics summary api to the new pipelines. (remain synchronous but use new patterns)
  • Build and use structures to support deterministic search
  • Build experimental metrics streaming API

Stretch

  • Measure/Improve job throughput. At least don't slow things down.
  • Issue multiple ingester search queries instead of one.

Existing/Relevant Issues

@joe-elliott joe-elliott self-assigned this Feb 20, 2024
@joe-elliott
Copy link
Member Author

We discovered some goroutine leaks in the existing implementation. Fix here:

#3495

@joe-elliott
Copy link
Member Author

Tags streaming:

#3460

@joe-elliott
Copy link
Member Author

Multiple ingester queries are being handled here:

#3574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant