Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a runtime config handler #893

Closed
annanay25 opened this issue Aug 19, 2021 · 0 comments · Fixed by #936
Closed

Add a runtime config handler #893

annanay25 opened this issue Aug 19, 2021 · 0 comments · Fixed by #936
Assignees

Comments

@annanay25
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I often want to access the tenant limits configured on a tempo instance through an HTTP API.

Describe the solution you'd like

Add a runtime config handler that provides information from the runtimeCfg manager.

Currently the runtimeCfg manager is implemented as a subservice of the Overrides module.

runtimeCfg := runtimeconfig.ManagerConfig{
LoadPath: defaults.PerTenantOverrideConfig,
ReloadPeriod: time.Duration(defaults.PerTenantOverridePeriod),
Loader: loadPerTenantOverrides,
}
runtimeCfgMgr, err := runtimeconfig.NewRuntimeConfigManager(runtimeCfg, prometheus.DefaultRegisterer)
if err != nil {
return nil, fmt.Errorf("failed to create runtime config manager %w", err)
}
tenantLimits = tenantLimitsFromRuntimeConfig(runtimeCfgMgr)
subservices = append(subservices, runtimeCfgMgr)

We should split the runtimeCfg manager as a separate service and register an API endpoint for it. Cortex implementation for reference:
https://github.com/cortexproject/cortex/blob/fbf067776f612ec33e7228430d4670ef566b57ec/pkg/cortex/modules.go#L150-L178

Describe alternatives you've considered

Additional context

@mapno mapno self-assigned this Aug 30, 2021
@mapno mapno mentioned this issue Sep 7, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants