From ac20d5b3d532c72443b9d5648c925b77b56f3a4d Mon Sep 17 00:00:00 2001 From: ankur22 Date: Thu, 1 Feb 2024 10:56:23 +0000 Subject: [PATCH] fixup! Add RemotePersister --- storage/file_persister.go | 4 ++-- storage/file_persister_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/storage/file_persister.go b/storage/file_persister.go index e239dbb1b..5a90cb0c2 100644 --- a/storage/file_persister.go +++ b/storage/file_persister.go @@ -101,7 +101,7 @@ func (r *RemoteFilePersister) Persist(ctx context.Context, path string, data io. } if err := checkStatusCode(resp); err != nil { - return fmt.Errorf("uploading status code out of range: %w", err) + return fmt.Errorf("uploading: %w", err) } return nil @@ -142,7 +142,7 @@ func (r *RemoteFilePersister) getPreSignedURL(ctx context.Context, path string) defer resp.Body.Close() //nolint:errcheck if err := checkStatusCode(resp); err != nil { - return "", fmt.Errorf("status code out of range: %w", err) + return "", err } return readResponseBody(resp) diff --git a/storage/file_persister_test.go b/storage/file_persister_test.go index ff4c2f975..1bcdab152 100644 --- a/storage/file_persister_test.go +++ b/storage/file_persister_test.go @@ -123,7 +123,7 @@ func TestRemoteFilePersister(t *testing.T) { "Run_id": "123456", }, getPresignedURLResponse: http.StatusTooManyRequests, - wantError: "getting presigned url: status code out of range: request is being rate limited", + wantError: "getting presigned url: request is being rate limited", }, { name: "get_presigned_fails", @@ -138,7 +138,7 @@ func TestRemoteFilePersister(t *testing.T) { "Run_id": "123456", }, getPresignedURLResponse: http.StatusInternalServerError, - wantError: "getting presigned url: status code out of range: status code is 500", + wantError: "getting presigned url: status code is 500", }, { name: "upload_rate_limited", @@ -154,7 +154,7 @@ func TestRemoteFilePersister(t *testing.T) { }, uploadResponse: http.StatusTooManyRequests, getPresignedURLResponse: http.StatusOK, - wantError: "uploading status code out of range: request is being rate limited", + wantError: "uploading: request is being rate limited", }, { name: "upload_fails", @@ -170,7 +170,7 @@ func TestRemoteFilePersister(t *testing.T) { }, uploadResponse: http.StatusInternalServerError, getPresignedURLResponse: http.StatusOK, - wantError: "uploading status code out of range: status code is 500", + wantError: "uploading: status code is 500", }, }