Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor goja runtime value parsing out of frame and page goto #1176

Closed
2 tasks done
Tracked by #1162
inancgumus opened this issue Jan 22, 2024 · 0 comments
Closed
2 tasks done
Tracked by #1162

Refactor goja runtime value parsing out of frame and page goto #1176

inancgumus opened this issue Jan 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@inancgumus
Copy link
Member

inancgumus commented Jan 22, 2024

What

Refactor the parsing of the option out of the promise and into the mapping layer for page.goto and frame.goto.

Why

This will help avoid a scenario where more than one off main goja thread goroutine (i.e., promise) is run concurrently, which could try to access the goji runtime concurrently and cause a panic.

How

Tasks

  1. inancgumus
@inancgumus inancgumus self-assigned this Jan 22, 2024
@inancgumus inancgumus changed the title Fix frame.goto Refactor goja runtime value parsing out of frame.goto Jan 22, 2024
@inancgumus inancgumus added the bug Something isn't working label Jan 22, 2024
@inancgumus inancgumus changed the title Refactor goja runtime value parsing out of frame.goto Refactor goja runtime value parsing out of page and frame goto Jan 24, 2024
@inancgumus inancgumus changed the title Refactor goja runtime value parsing out of page and frame goto Refactor goja runtime value parsing out of frame and page goto Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant