Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterise the HTTP request for uploading screenshots to a remote location #1342

Closed
2 tasks
Tracked by #1467
ankur22 opened this issue May 22, 2024 · 1 comment
Closed
2 tasks
Tracked by #1467
Labels
remote remote browser related

Comments

@ankur22
Copy link
Collaborator

ankur22 commented May 22, 2024

What?

At the moment we can setup almost everything required to upload a screenshot to a remote location:

  1. presignedURLGetter (used to retrieve the)
  2. the folder name (base path)
  3. Headers

What we do not have is the HTTP request method. It would be good if the http request was parameterised too (for both the presignedURLGetter and the presignedURL).

Why?

This will avoid having to make a change to k6 browser and wait for a release to change the screenshot upload remote URL characteristics.

How?

  1. The http request method will need to be added to an env var, maybe just append it to the existing env var (K6_BROWSER_SCREENSHOTS_OUTPUT).
  2. For the presignedURL itself, it would be good to have the request method type returned with the presigned url.

Tasks

Tasks

Related PR(s)/Issue(s)

No response

@ankur22 ankur22 added next Might be eligible for the next planning (not guaranteed!) remote remote browser related labels May 22, 2024
@inancgumus
Copy link
Member

Closing this as it's done by #1419. Regarding the presignedURL HTTP method, it should only be POST, as that is how AWS and the new v2 screenshot protocol work.

@inancgumus inancgumus removed the next Might be eligible for the next planning (not guaranteed!) label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote remote browser related
Projects
None yet
Development

No branches or pull requests

2 participants