Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support URL option for Page.waitForNavigation #253

Open
imiric opened this issue Feb 24, 2022 · 1 comment
Open

Support URL option for Page.waitForNavigation #253

imiric opened this issue Feb 24, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@imiric
Copy link
Contributor

imiric commented Feb 24, 2022

Currently the URL option for waitForNavigation is unused.

Previously it wasn't a major priority, but now that waiting for navigation within the same document works, we need a way to distinguish same document and new document navigations.

Suggested solution

Playwright handles this with the URL option, and it makes sense for us to do the same.

@imiric imiric added the enhancement New feature or request label Feb 24, 2022
@imiric imiric changed the title Support URL option for waitForNavigation Support URL option for Page.waitForNavigation Feb 24, 2022
@imiric
Copy link
Contributor Author

imiric commented Feb 25, 2022

Ah, I suppose this is a duplicate of #107, just with a different API. We should ensure they both expose the same implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants