Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse browser options from ENV #874

Closed
Tracked by #854
ka3de opened this issue May 9, 2023 · 1 comment
Closed
Tracked by #854

Parse browser options from ENV #874

ka3de opened this issue May 9, 2023 · 1 comment
Assignees
@ka3de
Labels
breaking PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@ka3de
Copy link
Collaborator

ka3de commented May 9, 2023 •
edited
Loading

Based on #856, the currently supported browser options should be modified to be parsed from environment. Specifically the options:

  • timeout
  • headless
  • debug
  • args
  • ignoreDefaultArgs
  • executablePath

Related: #856.
Related: #857.
@ka3de ka3de mentioned this issue May 9, 2023
Closed
@ka3de ka3de self-assigned this May 9, 2023
@ka3de ka3de added breaking PRs that need to be mentioned in the breaking changes section of the release notes refactor and removed refactor labels May 9, 2023
@ka3de ka3de changed the title Refactor browser options to be parsed from ENV Parse browser options from ENV May 9, 2023
@ka3de ka3de mentioned this issue May 9, 2023
Merged
3 tasks
@ka3de
Copy link
Collaborator Author

ka3de commented May 18, 2023

Closed by #876.

@ka3de ka3de closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ka3de ka3de

Labels
breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ka3de