From 0165db30d204c5cc4ab5642a0a3e7f95ba4cb3ac Mon Sep 17 00:00:00 2001 From: Jason Kuhrt Date: Wed, 10 Jul 2024 22:51:13 -0400 Subject: [PATCH 1/2] improve: test against node 20 and 22 --- .github/actions/setup/action.yaml | 2 +- .github/workflows/pr.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/setup/action.yaml b/.github/actions/setup/action.yaml index b77085aac..3f5993451 100644 --- a/.github/actions/setup/action.yaml +++ b/.github/actions/setup/action.yaml @@ -4,7 +4,7 @@ inputs: node-version: description: Version of Node to use. required: false - default: 18.x + default: 22.x install-deps: description: Should deps be installed? required: false diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index dabafc454..f58bb1397 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -31,7 +31,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [18, 20] + node: [20, 22] environment: [jsdom, node] name: Node ${{ matrix.node }} @env ${{matrix.environment}} steps: From 26ccda389528b4e1417172462da5a8b7a3de6a8b Mon Sep 17 00:00:00 2001 From: Jason Kuhrt Date: Wed, 10 Jul 2024 22:52:41 -0400 Subject: [PATCH 2/2] ts --- package.json | 2 +- pnpm-lock.yaml | 12 ++++++------ tsconfig.json | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 96b7921fd..5fb6ee97b 100644 --- a/package.json +++ b/package.json @@ -106,7 +106,7 @@ "@arethetypeswrong/cli": "^0.16.0", "@pothos/core": "^4.0.0", "@pothos/plugin-simple-objects": "^4.0.1", - "@tsconfig/node18": "^18.2.4", + "@tsconfig/node20": "^20.1.4", "@tsconfig/strictest": "^2.0.5", "@types/body-parser": "^1.19.5", "@types/express": "^4.17.21", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index a4ff3a7fd..ea4813c21 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -39,9 +39,9 @@ importers: '@pothos/plugin-simple-objects': specifier: ^4.0.1 version: 4.0.1(@pothos/core@4.0.0(graphql@16.9.0))(graphql@16.9.0) - '@tsconfig/node18': - specifier: ^18.2.4 - version: 18.2.4 + '@tsconfig/node20': + specifier: ^20.1.4 + version: 20.1.4 '@tsconfig/strictest': specifier: ^2.0.5 version: 2.0.5 @@ -671,8 +671,8 @@ packages: '@textlint/markdown-to-ast@12.6.1': resolution: {integrity: sha512-T0HO+VrU9VbLRiEx/kH4+gwGMHNMIGkp0Pok+p0I33saOOLyhfGvwOKQgvt2qkxzQEV2L5MtGB8EnW4r5d3CqQ==} - '@tsconfig/node18@18.2.4': - resolution: {integrity: sha512-5xxU8vVs9/FNcvm3gE07fPbn9tl6tqGGWA9tSlwsUEkBxtRnTsNmwrV8gasZ9F/EobaSv9+nu8AxUKccw77JpQ==} + '@tsconfig/node20@20.1.4': + resolution: {integrity: sha512-sqgsT69YFeLWf5NtJ4Xq/xAF8p4ZQHlmGW74Nu2tD4+g5fAsposc4ZfaaPixVu4y01BEiDCWLRDCvDM5JOsRxg==} '@tsconfig/strictest@2.0.5': resolution: {integrity: sha512-ec4tjL2Rr0pkZ5hww65c+EEPYwxOi4Ryv+0MtjeaSQRJyq322Q27eOQiFbuNgw2hpL4hB1/W/HBGk3VKS43osg==} @@ -3626,7 +3626,7 @@ snapshots: transitivePeerDependencies: - supports-color - '@tsconfig/node18@18.2.4': {} + '@tsconfig/node20@20.1.4': {} '@tsconfig/strictest@2.0.5': {} diff --git a/tsconfig.json b/tsconfig.json index ebf73a07b..068deae0c 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,7 +1,7 @@ { "extends": [ "@tsconfig/strictest/tsconfig.json", - "@tsconfig/node18/tsconfig.json" + "@tsconfig/node20/tsconfig.json" ], "compilerOptions": { "lib": ["DOM", "DOM.Iterable", "ES2023"],