Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIX_PATH can be clobbered by bashrc when using ./manage xx .shell #2

Open
3noch opened this issue Mar 28, 2017 · 2 comments
Open

NIX_PATH can be clobbered by bashrc when using ./manage xx .shell #2

3noch opened this issue Mar 28, 2017 · 2 comments
Assignees
Labels

Comments

@3noch
Copy link
Member

3noch commented Mar 28, 2017

If a user sets NIX_PATH in their ~/.bashrc file (or similar) then running ./manage <deployment> .shell will get the NIX_PATH as defined/overridden by the .bashrc file. This could be dangerous if you expect the environment to be safe and end up deploying a different channel than you expected.

@3noch 3noch self-assigned this Mar 28, 2017
@3noch 3noch added the bug label Mar 28, 2017
@eyeinsky
Copy link

eyeinsky commented Mar 26, 2020

Is this bug because nix-shell is run after exporting NIX_PATH in the manage script, and thus it overrides what nixpkgs-version.sh returns?

@3noch
Copy link
Member Author

3noch commented Mar 26, 2020

I believe so yes. Perhaps nix-shell -I would fix this, but probably not. I think nix-shell --command 'NIX_PATH=<the-one-we-want>' might fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants