-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lsp): Explicit type annotation code action #2125
Conversation
alex-snezhko
commented
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Alex! A really useful feature to add too, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions for you: what's with the version additions, and what happens if you use this code action on something that already has an annotation?
4ddd10e
to
8a5275c
Compare
@ospencer I got rid of the version stuff and it doesn't look like it made a difference actually (at least in VSCode's LSP client); I saw in the LSP documentation that the version was one of the response properties so that's why I implemented it initially. The code action dialog should no longer show if it's tried on something that's already annotated; I realized that there was actually a flaw in my implementation which sometimes showed the code action dialog on something that was already annotated, but I patched it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!