This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Update deps and stuff #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…approche, isn't it? ;)
passsy
reviewed
Sep 26, 2017
.travis.yml
Outdated
| @@ -43,7 +43,7 @@ before_script: | |||
| - adb shell input keyevent 82 & | |||
|
|
|||
| script: | |||
| - ./gradlew build jacocoTestReport assembleAndroidTest connectedCheck | |||
| - ./gradlew clean build jacocoTestReport assembleAndroidTest connectedCheck | |||
There was a problem hiding this comment.
why clean? It will delete all build artifacts from the before_script assemble step
passsy
reviewed
Sep 26, 2017
build.gradle
Outdated
| assertjVersion = '2.5.0' | ||
| mockitoVersion = '2.10.0' | ||
| assertjVersion = '2.8.0' | ||
| atslVersion = '1.0.1' |
There was a problem hiding this comment.
android test support library? I suggest supportTestVersion
passsy
reviewed
Sep 26, 2017
| supportLibraryVersion = '26.0.0' | ||
| // compositeAndroidVersion should be always the same version as the supportLib version | ||
| // Since composite is not up to date we can't use the latest one | ||
| compositeAndroidVersion = supportLibraryVersion |
|
I found that the travis.yml also includes |
… a good approche, isn't it? ;)" This reverts commit bbe0ee6.
|
Yes the same comment should be added to the build tools version |
passsy
reviewed
Sep 27, 2017
build.gradle
Outdated
|
|
||
| supportLibraryVersion = '25.2.0' | ||
| supportLibraryVersion = '26.0.0' |
There was a problem hiding this comment.
why not 26.1.0. It includes LifecycleObserver which we could use for #109?
There was a problem hiding this comment.
Because of #115 (comment) 🙃
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just updated all of our dependencies to the current latest version.