This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Feature: restrict TiFragment api for subclasses #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2017 17:48
…om the DelegatedTiFragment interface as final so they cannot be overridden by subclasses.
… requires calling the super implementation because TiFragment uses this lifecycle methods to manage the TiFragmentDelegate instance.
ghost
changed the title
ghost
requested review from
passsy
approved these changes
Apr 4, 2017
|
Do the same for |
|
@passsy I'm not sure whether or not |
|
|
…tivityPlugin and the TiFragmentPlugin.
|
I applied your suggestions to the |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restricts the
TiFragmentapi by declaring some implemented methods from theDelegatedTiFragment-Interface asfinalso they cannot be overridden by subclasses.It also adds the
@CallSuper-Annotation to all important lifecycle methods that requires calling the super implementation becauseTiFragmentuses this lifecycle methods to manage theTiFragmentDelegateinstance.This should help to prevent issues which are caused by extending
TiFragmentand not call its respective super implementations (see #29 for example).@passsy suggested to use the
FragmentManager.FragmentLifecycleCallbacks(https://developer.android.com/reference/android/support/v4/app/FragmentManager.FragmentLifecycleCallbacks.html) to enforce the calls on the managedTiFragmentDelegateinstance but since we are trying to hit the 0.8.0 release i think this would be a rather drastic improvement.