Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultSeccompProfile = "/etc/sysconfig/manhattan.json" #17

Open
runcom opened this issue Jun 22, 2016 · 11 comments
Open

defaultSeccompProfile = "/etc/sysconfig/manhattan.json" #17

runcom opened this issue Jun 22, 2016 · 11 comments

Comments

@runcom
Copy link
Contributor

runcom commented Jun 22, 2016

is that value correct? manhattan.json?

Also, what default.json does in this repository?

@grantseltzer
Copy link
Owner

grantseltzer commented Jun 22, 2016

@runcom The name is arbitrary. The install option should move default.json to that location. If you have no objection to that idea I'll add it to the makefile and write about it in the README.md

@runcom
Copy link
Contributor Author

runcom commented Jun 22, 2016

Is the default coming from Docker? If that's the case I'd prefer docker installation to take care of installing it or otherwise it won't always be in sync

@grantseltzer
Copy link
Owner

Yes it is, and sure. Do you know if when Docker is installed if a default seccomp profile is placed somewhere?

@runcom
Copy link
Contributor Author

runcom commented Jun 22, 2016

It isn't (I'm maintaining the package in Fedora)

We shall leave this opened to track this

@grantseltzer
Copy link
Owner

For now should I do it the way I originally suggested?

@runcom
Copy link
Contributor Author

runcom commented Jun 22, 2016

yes, we'll remove the Makefile target after we fix docker installation

@grantseltzer
Copy link
Owner

👍

@grantseltzer
Copy link
Owner

Leaving this open for now

@rhatdan
Copy link

rhatdan commented Jun 22, 2016

Yes it would be out of date. Having it rely on docker is not great either, especially where we would like to support pure OCI environments.

@runcom
Copy link
Contributor Author

runcom commented Jun 22, 2016

Yes it would be out of date. Having it rely on docker is not great either, especially where we would like to support pure OCI environments.

right, my proposal is then to have ocitools generate a default profile /cc @mrunalp

@rhatdan
Copy link

rhatdan commented Jun 22, 2016

Ok that would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants