Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of examples/social code? #506

Closed
marcelvanwaaijen opened this issue Mar 17, 2022 · 0 comments · Fixed by #510
Closed

cleanup of examples/social code? #506

marcelvanwaaijen opened this issue Mar 17, 2022 · 0 comments · Fixed by #510

Comments

@marcelvanwaaijen
Copy link

Looks like there is still some old code in the "social" example. If that is the case, is is possible to clean that? It might be confusing for people starting with graphql-go and trying to educate by example (like me) ;-)

@marcelvanwaaijen I haven't looked into it in details but my wild guess is that it was an existing example and when this feature was implemented we ended up adding graphql.UseFieldResolvers() which uses fields instead of methods. Then we started using the fields and stopped using the method. I would suggest opening a separate issue if this is the case as this one was related to adding the field resolvers feature, which is already done.

Originally posted by @pavelnikolov in #282 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants