Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseSDL startsWith import #94

Closed
djeeg opened this issue Feb 26, 2018 · 1 comment
Closed

parseSDL startsWith import #94

djeeg opened this issue Feb 26, 2018 · 1 comment

Comments

@djeeg
Copy link

djeeg commented Feb 26, 2018

Hi, thanks for the library! starting to use it to break apart my schema file, looks very promising

Small question, would you be open to changing this line?

https://github.com/graphcool/graphql-import/blob/master/src/index.ts#L63

.filter(l => l.startsWith('# import') || l.startsWith('#import'))

to (ie spaces after import)

.filter(l => l.startsWith('# import ') || l.startsWith('#import '))

Our team have a tendancy to add comments lines like this:

#importent: DONT add types that will causes import cycles

And those lines get rejected by here:
https://github.com/graphcool/graphql-import/blob/master/src/index.ts#L39

@schickling
Copy link
Contributor

Absolutely, great point! Please create a PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants