We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, thanks for the library! starting to use it to break apart my schema file, looks very promising
Small question, would you be open to changing this line?
https://github.com/graphcool/graphql-import/blob/master/src/index.ts#L63
.filter(l => l.startsWith('# import') || l.startsWith('#import'))
to (ie spaces after import)
.filter(l => l.startsWith('# import ') || l.startsWith('#import '))
Our team have a tendancy to add comments lines like this:
#importent: DONT add types that will causes import cycles
And those lines get rejected by here: https://github.com/graphcool/graphql-import/blob/master/src/index.ts#L39
The text was updated successfully, but these errors were encountered:
Absolutely, great point! Please create a PR! :)
Sorry, something went wrong.
9bd6064
No branches or pull requests
Hi, thanks for the library! starting to use it to break apart my schema file, looks very promising
Small question, would you be open to changing this line?
https://github.com/graphcool/graphql-import/blob/master/src/index.ts#L63
.filter(l => l.startsWith('# import') || l.startsWith('#import'))
to (ie spaces after import)
.filter(l => l.startsWith('# import ') || l.startsWith('#import '))
Our team have a tendancy to add comments lines like this:
And those lines get rejected by here:
https://github.com/graphcool/graphql-import/blob/master/src/index.ts#L39
The text was updated successfully, but these errors were encountered: