Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling the Cost Model in other networks than mainnet #707

Closed
tilacog opened this issue Aug 11, 2023 · 6 comments
Closed

Allow enabling the Cost Model in other networks than mainnet #707

tilacog opened this issue Aug 11, 2023 · 6 comments
Labels
enhancement New feature or request p1

Comments

@tilacog
Copy link
Contributor

tilacog commented Aug 11, 2023

After the multi-network changes introduced in 668, the Cost Model feature was restricted to Ethereum Mainnet.
We should find a way to enable this feature for other networks besides that.

Originally posted by @fordN in #668 (comment)

@tilacog tilacog self-assigned this Aug 11, 2023
@tilacog tilacog added this to Indexer Aug 11, 2023
@github-project-automation github-project-automation bot moved this to 🗃️ Inbox in Indexer Aug 11, 2023
@tilacog tilacog added the enhancement New feature or request label Aug 11, 2023
@tilacog tilacog removed their assignment Aug 11, 2023
@fordN fordN added the p1 label Aug 11, 2023
@fordN fordN moved this from 🗃️ Inbox to 🙏 Feature Requests in Indexer Aug 11, 2023
@madumas
Copy link

madumas commented Sep 5, 2023

If the roadblock is the availability of GRT/DAI uniswap pairs on other network, the agent should still allow using cost models when inject-dai=off.

@fordN
Copy link
Contributor

fordN commented Sep 6, 2023

Gathering some notes from a quick brainstorming session with @tilacog

Tasks to do

  • Update code to support cost-models on each network: ensure data models include protocolNetwork, etc...
  • Decide and implement network agnostic approach to fetching GRT/DAI pair price

Some initial ideas for network agnostic approaches to fetching price:

  • Create a small, specific subgraph tracking the GRT/DAI or GRT/USD pairs on Uniswap (and maybe other protocols too?)
  • Simply use the GRT/DAI price from Mainnet across all networks
  • ....

@abarmat
Copy link
Collaborator

abarmat commented Nov 2, 2023

I think that for the purpose of the cost model we could just use the data from Ethereum. What's important is that the oracle we use has enough volume.

@abarmat
Copy link
Collaborator

abarmat commented Nov 2, 2023

Other ones to investigate: https://docs.mean.finance/v/oracles/ and https://docs.oracles.rip/content/what-is-price.html - also this one for offchain oracles https://github.com/mean-finance/sdk

@fordN fordN moved this from 🙏 Feature Requests to 📒 Todo in Indexer Feb 12, 2024
@alex-pakalniskis
Copy link
Contributor

#899

@fordN fordN moved this from 📒 Todo to Up next in Indexer Jul 8, 2024
@alex-pakalniskis
Copy link
Contributor

edgeandnode/gateway#971

@alex-pakalniskis alex-pakalniskis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
@github-project-automation github-project-automation bot moved this from 📒 Todo to ❌ Closed in Indexer Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1
Projects
Status: Closed
Development

No branches or pull requests

6 participants