Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Shio framework. #96

Closed
thedodd opened this issue Oct 11, 2017 · 5 comments
Closed

Integration with Shio framework. #96

thedodd opened this issue Oct 11, 2017 · 5 comments

Comments

@thedodd
Copy link

thedodd commented Oct 11, 2017

Shio is a promising framework which has cropped up over the last few months. It has some immense throughput potential with async I/O distributed across a threadpool of event loops. It would be awesome to build out an integration with this framework, perhaps as a pre-built integration, or in a separate crate.

Integration with a framework that can achieve async I/O level throughput is critical for production adoption of Juniper in my case.

Currently I'm using a nodejs implementation, and being able to use Rust for this would be a huge win 🙌 . I use a lot of Go as well, but I greatly prefer Rust and use it where I can, and the Go graphql libs are not so awesome, IMHO.

I've looked at the discussion going on in the #2 interop with async issue. Being able to take a stab at it, to see where the walls are, may be beneficial. I would love to spike this, but I definitely wanted to get some discussion going around this.

Any and all feedback is welcome.


Great work on this lib so far. Once the async I/O story is g2g, I can definitely see this as being the most solid, convenient, productive, and powerful GraphQL option across the field of languages to chose from.

@theduke
Copy link
Member

theduke commented Oct 11, 2017

The iron and rocket integrations were initially part of the library, but were extracted into their own crates, so all other framework integrations also should live in their own crates.

These crates are mostly some small glue code, so I think we'd definitely accept a juniper_shio crate if someone wants to step up and write it up. I'll create a new repo and development can happen there.

Regarding async, I have a lengthy comment regarding my vision for async which I haven't posted yet, but I'm very interested in async as will, and think it's crucial for scalable production grade GraphQL!

@thedodd
Copy link
Author

thedodd commented Feb 6, 2018

I've built an integration with the gotham framework. Was very simple to get up and running. No need for this issue anymore.

@thedodd thedodd closed this as completed Feb 6, 2018
@theduke
Copy link
Member

theduke commented Feb 6, 2018

@thedodd would you find it sensible to release a juniper_gotham crate which contains the integration?

We'd be happy to accept it into the repo.

@theduke
Copy link
Member

theduke commented Feb 6, 2018

Otherwise, just a link to some open source example code would probably help users a lot.

@kamek-pf
Copy link

kamek-pf commented Feb 7, 2018

@theduke did you ever post that lengthy comment regarding async IO ? Really curious how this can be dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants