From 687b28e0298cbc41563b34f4b6f653d45e267e21 Mon Sep 17 00:00:00 2001 From: Leonard Ehrenfried Date: Mon, 28 Aug 2023 13:00:47 +0200 Subject: [PATCH 1/4] Update development instructions --- DEVELOPMENT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index b4c17ab4d7b..2c5b612bda4 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -44,7 +44,7 @@ this repo._ If you are focused on GraphiQL development, you can run — ```sh - yarn start-graphiql + yarn dev-graphiql ``` 5. Get coding! If you've added code, add tests. If you've changed APIs, update From ce09e53ed59e4909b5cb0db4ad58e2a5fa7c7d52 Mon Sep 17 00:00:00 2001 From: Leonard Ehrenfried Date: Mon, 28 Aug 2023 13:01:27 +0200 Subject: [PATCH 2/4] Don't convert single \n to
--- packages/graphiql-react/src/markdown.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/graphiql-react/src/markdown.ts b/packages/graphiql-react/src/markdown.ts index 9386e370973..1e26795a8c1 100644 --- a/packages/graphiql-react/src/markdown.ts +++ b/packages/graphiql-react/src/markdown.ts @@ -1,6 +1,8 @@ import MarkdownIt from 'markdown-it'; export const markdown = new MarkdownIt({ - breaks: true, + // we don't want to convert \n to
because in markdown a single newline is not a line break + // https://github.com/graphql/graphiql/issues/3155 + breaks: false, linkify: true, }); From a6e9612db76b89ee3ffc9e8cb83ca66306a722a2 Mon Sep 17 00:00:00 2001 From: Leonard Ehrenfried Date: Wed, 27 Sep 2023 19:30:52 +0200 Subject: [PATCH 3/4] Add changeset --- .changeset/olive-mice-hide.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/olive-mice-hide.md diff --git a/.changeset/olive-mice-hide.md b/.changeset/olive-mice-hide.md new file mode 100644 index 00000000000..82e49707689 --- /dev/null +++ b/.changeset/olive-mice-hide.md @@ -0,0 +1,6 @@ +--- +'graphiql': minor +'@graphiql/react': minor +--- + +Respect Markdown format: ignore single newline From b4c38d05457e58fec738691647dc74f961e2fed8 Mon Sep 17 00:00:00 2001 From: Dimitri POSTOLOV Date: Wed, 14 Aug 2024 19:59:50 +0200 Subject: [PATCH 4/4] Update .changeset/olive-mice-hide.md --- .changeset/olive-mice-hide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/olive-mice-hide.md b/.changeset/olive-mice-hide.md index 82e49707689..2606c7cae1c 100644 --- a/.changeset/olive-mice-hide.md +++ b/.changeset/olive-mice-hide.md @@ -1,6 +1,6 @@ --- -'graphiql': minor -'@graphiql/react': minor +'graphiql': patch +'@graphiql/react': patch --- Respect Markdown format: ignore single newline