Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: flag for old, deprecated variable scalar coercion behavior #1519

Closed
dallonf opened this issue Sep 10, 2018 · 2 comments
Closed

Comments

@dallonf
Copy link

dallonf commented Sep 10, 2018

To start, I think the changes made in #1382 are good and definitely the direction GraphQL should be going!

However, for my team, this is a huge breaking change that will prevent us from updating to 14.x or later for the forseeable future. I suspect there are many client applications depending on our GraphQL server that send incorrect variable types, expecting them to be coerced. Right now I'm just doing a bit of housekeeping on the dependencies of the server - I simply don't have the bandwidth to go through all of these client applications and fix them, or even to investigate where this might be happening.

Previous breaking changes (ex. #927) have provided flags and options to affected functions - can we get one of those for this change? This would allow my team to at least stay up to date and save this chore for another time.

@IvanGoncharov
Copy link
Member

@dallonf Sorry for the trouble this change caused.

Previous breaking changes (ex. #927) have provided flags and options to affected functions - can we get one of those for this change?

The difference here is that GraphQLInt, GraphQLFloat and others are singletons so we can't pass a flag to them or wrap them.

It would be great if someone will figure out some way to implement it in a clean way?
@leebyron If you have time, can you please comment on this issue?

@IvanGoncharov
Copy link
Member

Closing issue since no solution was suggested.
Note: since graphql typically used a peer dependency you don't tie to a particular version and can migrate to 14.0.0 after you will upgrade your clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants