Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make onError optional in SDLValidationContext #2169

Merged

Conversation

Cito
Copy link
Member

@Cito Cito commented Sep 14, 2019

The onError argument was probably meant to be optional,
just like in ASTValidationContext and ValidationContext.

@IvanGoncharov IvanGoncharov merged commit a5e0b64 into graphql:master Sep 14, 2019
@IvanGoncharov
Copy link
Member

Thanks 👍Merged 🎉
Note: in 15.0.0 it will become required see:
https://github.com/graphql/graphql-js/pull/2130/files

@Cito
Copy link
Member Author

Cito commented Sep 14, 2019

Because the error collection will not be done automatically any more, so you will always need this, right?

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Sep 15, 2019
@Cito Cito deleted the fix-sdl-validation-context-constructor branch September 25, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants