Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground session based auth, not sending cookie in the request. #364

Closed
2 tasks
gmahe opened this issue Dec 21, 2017 · 5 comments · Fixed by #470
Closed
2 tasks

playground session based auth, not sending cookie in the request. #364

gmahe opened this issue Dec 21, 2017 · 5 comments · Fixed by #470

Comments

@gmahe
Copy link

gmahe commented Dec 21, 2017

This issue pertains to the following package(s):

  • GraphQL Playground
  • GraphQL Playground Express Middleware

What OS and OS version are you experiencing the issue(s) on?

Chrome/Opera

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.3.6

What is the expected behavior?

Send cookie on the request.

What is the actual behavior?

Not sending the cookie in the request, unlike graphiQL.

What steps may we take to reproduce the behavior?

We're using passport-local as a middleware.
We use the mutation login and if it works we get back a cookie.
If I want to check who is the current user, I send my query and the cookie (passport) should be included in the request where the resolver should return either the current user or null in case the user has logout or if the cookie wasn't sent.

what graphiQL is sending:
screen shot 2017-12-21 at 16 24 40
What playground is sending:
screen shot 2017-12-21 at 16 24 18

@vincenzo
Copy link
Contributor

I confirm this one is still a problem with Playground 1.3.10 (included in Yoga 0.4.4)

@vincenzo
Copy link
Contributor

/cc @timsuchanek @kbrandwijk

I'd love if this issue could get priority attention, as it's affecting us in our development (we use Yoga). If there's anyone else that should be explicitly tagged, please do.

@huv1k
Copy link
Collaborator

huv1k commented Dec 27, 2017

@vincenzo You can always chip in and help with it :)

@vincenzo
Copy link
Contributor

@HuVik I'd love to, but I am new to all this and don't really know where to start to fix this one, sorry :) Maybe someone in my team could help. I'll ask.

@vincenzo
Copy link
Contributor

vincenzo commented Jan 5, 2018

@HuVik @timsuchanek Any of you could give me a steer in the right direction, here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants