Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in Participant comparison #1

Closed
Changaco opened this issue Feb 20, 2015 · 2 comments
Closed

bug in Participant comparison #1

Changaco opened this issue Feb 20, 2015 · 2 comments
Labels

Comments

@Changaco
Copy link
Contributor

Description: the comparison participant != None returns False instead of True.

Origin of the bug: gratipay/gratipay.com@a25a4bb#diff-278aa1963da2c7006b0639e16b0130d9R47

Severity: low, I haven't been able to find any exploitable code.

Fix:

--- a/gratipay/models/participant.py
+++ b/gratipay/models/participant.py
@@ -78,7 +78,7 @@ class Participant(Model, MixinTeam):

     def __ne__(self, other):
         if not isinstance(other, Participant):
-            return False
+            return True
         return self.username != other.username

     def __repr__(self):
@Changaco
Copy link
Contributor Author

@whit537 I have a branch ready for this, should I open a PR ?

@chadwhitacre
Copy link

@Changaco I think we should figure out how to fix security bugs on a fork in this private repo. It's not a big deal here but better to learn the process here than on a higher-risk bug. cf. gratipay/security-00003#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants