Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove stun #2396

Merged
merged 4 commits into from
Jun 28, 2023
Merged

remove stun #2396

merged 4 commits into from
Jun 28, 2023

Conversation

afeiszli
Copy link
Contributor

@afeiszli afeiszli commented Jun 13, 2023 •
edited
Loading

Describe your changes

Removed the server's STUN capabilities.

Provide Issue ticket number if applicable/not in title

Provide testing steps

Just needs a basic check to make sure everything is functioning as expected.

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@afeiszli afeiszli marked this pull request as ready for review June 27, 2023 18:43
theguy951357
theguy951357 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical list passes

@afeiszli afeiszli merged commit 0046bae into develop Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theguy951357 theguy951357 theguy951357 approved these changes

@mattkasun mattkasun mattkasun approved these changes

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@abhishek9686 abhishek9686 Awaiting requested review from abhishek9686

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afeiszli @theguy951357 @mattkasun