From 9801d334b9cb6c8bdc30d982020f447a1185f744 Mon Sep 17 00:00:00 2001
From: Valerii Sidorenko <balepas@nebius.com>
Date: Wed, 11 Sep 2024 14:33:08 +0200
Subject: [PATCH] feat(Select): pass aria attributes to render functions
 (#1841)

---
 .../Select/__stories__/Select.stories.tsx     |  7 +--
 .../Select/__stories__/SelectShowcase.tsx     | 34 +++++++----
 .../SelectControl/SelectControl.tsx           | 47 +++++++++------
 .../components/SelectFilter/SelectFilter.scss |  6 +-
 .../components/SelectFilter/SelectFilter.tsx  | 31 +++++++---
 src/components/Select/i18n/en.json            |  3 +-
 src/components/Select/i18n/ru.json            |  3 +-
 src/components/Select/types.ts                | 58 +++++++++++++++----
 8 files changed, 132 insertions(+), 57 deletions(-)

diff --git a/src/components/Select/__stories__/Select.stories.tsx b/src/components/Select/__stories__/Select.stories.tsx
index 92feca1f36..2a2588623e 100644
--- a/src/components/Select/__stories__/Select.stories.tsx
+++ b/src/components/Select/__stories__/Select.stories.tsx
@@ -3,14 +3,13 @@ import React from 'react';
 import type {Meta, StoryObj} from '@storybook/react';
 
 import {Select} from '..';
-import type {SelectProps} from '..';
 import {Button} from '../../Button';
 
 import {SelectPopupWidthShowcase} from './SelectPopupWidthShowcase';
 import {SelectShowcase} from './SelectShowcase';
 import {UseSelectOptionsShowcase} from './UseSelectOptionsShowcase';
 
-const meta: Meta = {
+const meta: Meta<typeof Select> = {
     title: 'Components/Inputs/Select',
     component: Select,
     parameters: {
@@ -31,7 +30,7 @@ const meta: Meta = {
 
 export default meta;
 
-type Story = StoryObj<SelectProps>;
+type Story = StoryObj<typeof Select>;
 
 export const Default = {
     render: (args) => (
@@ -45,7 +44,7 @@ export const Default = {
 } satisfies Story;
 
 export const Showcase = {
-    render: (args: SelectProps) => <SelectShowcase {...args} />,
+    render: (args) => <SelectShowcase {...args} />,
     args: {
         view: 'normal',
         size: 'm',
diff --git a/src/components/Select/__stories__/SelectShowcase.tsx b/src/components/Select/__stories__/SelectShowcase.tsx
index 36f7f25d91..2ce69cb6d0 100644
--- a/src/components/Select/__stories__/SelectShowcase.tsx
+++ b/src/components/Select/__stories__/SelectShowcase.tsx
@@ -120,14 +120,18 @@ export const SelectShowcase = (props: SelectProps) => {
     const [matchCase, setMatchCase] = React.useState(false);
     const [matchWholeWord, setMatchWholeWord] = React.useState(false);
 
-    const renderFilter: SelectProps['renderFilter'] = ({value, ref, onChange, onKeyDown}) => {
+    const renderFilter: SelectProps['renderFilter'] = ({
+        ref,
+        style,
+        inputProps: {value, onChange, onKeyDown, ...controlProps},
+    }) => {
         return (
-            <div style={{display: 'flex', flexDirection: 'column', rowGap: 4}}>
+            <div style={{...style, display: 'flex', flexDirection: 'column', rowGap: 4}}>
                 <TextInput
                     controlRef={ref}
-                    controlProps={{size: 1}}
+                    controlProps={controlProps}
                     value={value}
-                    onUpdate={onChange}
+                    onChange={onChange}
                     onKeyDown={onKeyDown}
                 />
                 <div style={{display: 'flex', columnGap: 2}}>
@@ -281,20 +285,26 @@ export const SelectShowcase = (props: SelectProps) => {
                 selectProps={{
                     ...props,
                     className: b('user-control'),
-                    renderControl: ({onClick, onKeyDown, ref, renderClear, disabled}) => {
+                    renderControl: ({
+                        ref,
+                        renderClear,
+                        triggerProps: {onClick, disabled, id, ...extraProps},
+                    }) => {
                         return (
                             <Button
+                                id={id}
                                 ref={ref}
                                 view="action"
                                 onClick={onClick}
                                 disabled={disabled}
                                 extraProps={{
-                                    onKeyDown,
+                                    ...extraProps,
+                                    'aria-label': extraProps['aria-label'] || 'User control',
                                 }}
                                 className={b({'has-clear': props.hasClear})}
                             >
                                 <span className={b('text')}>User control</span>
-                                {renderClear?.({
+                                {renderClear({
                                     renderIcon: () => (
                                         <Icon data={TrashBin} className={b('user-clear-icon')} />
                                     ),
@@ -317,16 +327,20 @@ export const SelectShowcase = (props: SelectProps) => {
                     ...props,
                     className: b('user-control-placement'),
                     popupPlacement: ['bottom'],
-                    renderControl: ({onClick, onKeyDown, ref, disabled}) => {
+                    renderControl: ({
+                        ref,
+                        triggerProps: {onClick, disabled, id, ...extraProps},
+                    }) => {
                         return (
                             <Button
+                                id={id}
                                 ref={ref}
                                 view="action"
                                 onClick={onClick}
                                 disabled={disabled}
                                 extraProps={{
-                                    onKeyDown,
-                                    'aria-label': 'Add',
+                                    ...extraProps,
+                                    'aria-label': extraProps['aria-label'] || 'Add',
                                 }}
                             >
                                 <Icon data={Plus} />
diff --git a/src/components/Select/components/SelectControl/SelectControl.tsx b/src/components/Select/components/SelectControl/SelectControl.tsx
index 9f7a009f59..8b764280a6 100644
--- a/src/components/Select/components/SelectControl/SelectControl.tsx
+++ b/src/components/Select/components/SelectControl/SelectControl.tsx
@@ -15,8 +15,8 @@ import type {
     SelectProps,
     SelectRenderClearArgs,
     SelectRenderControl,
-    SelectRenderControlProps,
     SelectRenderCounter,
+    SelectRenderTriggerProps,
 } from '../../types';
 import {SelectClear} from '../SelectClear/SelectClear';
 import {SelectCounter} from '../SelectCounter/SelectCounter';
@@ -38,12 +38,17 @@ type ControlProps = {
     isErrorVisible?: boolean;
     errorMessage?: SelectProps['errorMessage'];
     disabled?: boolean;
-    value: SelectProps['value'];
+    value: NonNullable<SelectProps['value']>;
     clearValue: () => void;
     hasClear?: boolean;
     hasCounter?: boolean;
     title?: string;
-} & Omit<SelectRenderControlProps, 'onClick' | 'onClear' | 'renderCounter'>;
+    onKeyDown?: (e: React.KeyboardEvent<HTMLElement>) => void;
+    open: boolean;
+    popupId: string;
+    selectId: string;
+    activeIndex?: number;
+};
 
 export const SelectControl = React.forwardRef<HTMLButtonElement, ControlProps>((props, ref) => {
     const {
@@ -128,7 +133,7 @@ export const SelectControl = React.forwardRef<HTMLButtonElement, ControlProps>((
         if (!hasCounter) {
             return null;
         }
-        const count = Number(value?.length) || 0;
+        const count = value.length;
         const counterComponent = <SelectCounter count={count} size={size} disabled={disabled} />;
         return renderCounter
             ? renderCounter(counterComponent, {count, size, disabled})
@@ -136,8 +141,8 @@ export const SelectControl = React.forwardRef<HTMLButtonElement, ControlProps>((
     };
 
     const renderClearIcon = (args: SelectRenderClearArgs) => {
-        const hideOnEmpty = !value?.[0];
-        if (!hasClear || !clearValue || hideOnEmpty || disabled) {
+        const valueIsEmpty = value.length === 0;
+        if (!hasClear || valueIsEmpty || disabled) {
             return null;
         }
         return (
@@ -151,20 +156,34 @@ export const SelectControl = React.forwardRef<HTMLButtonElement, ControlProps>((
         );
     };
 
+    const triggerProps: SelectRenderTriggerProps = {
+        id: selectId,
+        role: 'combobox',
+        'aria-controls': open ? popupId : undefined,
+        'aria-haspopup': 'listbox',
+        'aria-expanded': open,
+        'aria-activedescendant':
+            activeIndex === undefined ? undefined : `${popupId}-item-${activeIndex}`,
+        onClick: handleControlClick,
+        onKeyDown,
+        disabled,
+    };
+
     if (renderControl) {
         return renderControl(
             {
                 onKeyDown,
                 onClear: clearValue,
                 onClick: handleControlClick,
-                renderClear: (arg) => renderClearIcon(arg),
+                renderClear: renderClearIcon,
                 renderCounter: renderCounterComponent,
                 ref,
-                open: Boolean(open),
+                open,
                 popupId,
                 selectId,
                 activeIndex,
                 disabled,
+                triggerProps,
             },
             {value},
         );
@@ -174,23 +193,13 @@ export const SelectControl = React.forwardRef<HTMLButtonElement, ControlProps>((
         <React.Fragment>
             <div className={selectControlBlock(controlMods)} role="group">
                 <button
-                    id={selectId}
                     ref={ref}
-                    role="combobox"
-                    aria-controls={open ? popupId : undefined}
                     className={selectControlButtonBlock(buttonMods, className)}
-                    aria-haspopup="listbox"
-                    aria-expanded={open}
-                    aria-activedescendant={
-                        activeIndex === undefined ? undefined : `${popupId}-item-${activeIndex}`
-                    }
-                    disabled={disabled}
-                    onClick={handleControlClick}
-                    onKeyDown={onKeyDown}
                     type="button"
                     data-qa={qa}
                     title={title}
                     tabIndex={0}
+                    {...triggerProps}
                 >
                     {label && <span className={selectControlBlock('label')}>{label}</span>}
                     {showPlaceholder && (
diff --git a/src/components/Select/components/SelectFilter/SelectFilter.scss b/src/components/Select/components/SelectFilter/SelectFilter.scss
index 8c9c819e63..da09761f2b 100644
--- a/src/components/Select/components/SelectFilter/SelectFilter.scss
+++ b/src/components/Select/components/SelectFilter/SelectFilter.scss
@@ -4,9 +4,5 @@ $block: '.#{variables.$ns}select-filter';
 
 #{$block} {
     // To prevent border blink when the focus is set frequently (in case of option click)
-    & &__input,
-    & &__input:hover,
-    & &__input:focus {
-        border-color: var(--g-color-line-generic-active);
-    }
+    --g-text-input-border-color: var(--g-color-line-generic-active);
 }
diff --git a/src/components/Select/components/SelectFilter/SelectFilter.tsx b/src/components/Select/components/SelectFilter/SelectFilter.tsx
index 0803cb761c..fbfb9e2898 100644
--- a/src/components/Select/components/SelectFilter/SelectFilter.tsx
+++ b/src/components/Select/components/SelectFilter/SelectFilter.tsx
@@ -5,7 +5,8 @@ import React from 'react';
 import {TextInput} from '../../../controls';
 import {block} from '../../../utils/cn';
 import {SelectQa} from '../../constants';
-import type {SelectProps} from '../../types';
+import i18n from '../../i18n';
+import type {SelectFilterInputProps, SelectProps} from '../../types';
 import type {SelectFilterRef} from '../../types-misc';
 
 import './SelectFilter.scss';
@@ -40,18 +41,34 @@ export const SelectFilter = React.forwardRef<SelectFilterRef, SelectFilterProps>
         [],
     );
 
-    return renderFilter ? (
-        renderFilter({onChange, onKeyDown, value, ref: inputRef, style})
-    ) : (
+    const inputProps: SelectFilterInputProps = {
+        value,
+        placeholder,
+        size: 1,
+        onKeyDown,
+        onChange: (e) => {
+            onChange(e.target.value);
+        },
+        'aria-label': i18n('label_filter'),
+        'aria-controls': popupId,
+        'aria-activedescendant':
+            activeIndex === undefined ? undefined : `${popupId}-item-${activeIndex}`,
+    };
+
+    if (renderFilter) {
+        return renderFilter({onChange, onKeyDown, value, ref: inputRef, style, inputProps});
+    }
+
+    return (
         <div className={b()} style={style}>
             <TextInput
                 controlRef={inputRef}
                 controlProps={{
                     className: b('input'),
                     size: 1,
-                    'aria-controls': popupId,
-                    'aria-activedescendant':
-                        activeIndex === undefined ? undefined : `${popupId}-item-${activeIndex}`,
+                    'aria-label': inputProps['aria-label'],
+                    'aria-controls': inputProps['aria-controls'],
+                    'aria-activedescendant': inputProps['aria-activedescendant'],
                 }}
                 size={size}
                 value={value}
diff --git a/src/components/Select/i18n/en.json b/src/components/Select/i18n/en.json
index c0e9d0b76b..109bc074a2 100644
--- a/src/components/Select/i18n/en.json
+++ b/src/components/Select/i18n/en.json
@@ -1,4 +1,5 @@
 {
   "label_clear": "Clear",
-  "label_show-error-info": "Show popup with error info"
+  "label_show-error-info": "Show popup with error info",
+  "label_filter": "Filter"
 }
diff --git a/src/components/Select/i18n/ru.json b/src/components/Select/i18n/ru.json
index 64b4545abe..84691bcfff 100644
--- a/src/components/Select/i18n/ru.json
+++ b/src/components/Select/i18n/ru.json
@@ -1,4 +1,5 @@
 {
   "label_clear": "Очистить",
-  "label_show-error-info": "Показать попап с информацей об ошибке"
+  "label_show-error-info": "Показать попап с информацей об ошибке",
+  "label_filter": "Фильтр"
 }
diff --git a/src/components/Select/types.ts b/src/components/Select/types.ts
index b9a77a7be0..7f88949748 100644
--- a/src/components/Select/types.ts
+++ b/src/components/Select/types.ts
@@ -3,7 +3,7 @@ import type React from 'react';
 import type {PopperPlacement} from '../../hooks/private';
 import type {UseOpenProps} from '../../hooks/useSelect/types';
 import type {InputControlPin, InputControlSize, InputControlView} from '../controls';
-import type {ControlGroupOption, QAProps} from '../types';
+import type {AriaLabelingProps, ControlGroupOption, QAProps} from '../types';
 
 import type {Option, OptionGroup} from './tech-components';
 
@@ -11,19 +11,41 @@ export type SelectRenderClearArgs = {
     renderIcon?: () => React.ReactNode;
 };
 
+export type SelectRenderTriggerProps = AriaLabelingProps &
+    Pick<
+        React.ButtonHTMLAttributes<HTMLElement>,
+        | 'id'
+        | 'type'
+        | 'role'
+        | 'aria-controls'
+        | 'aria-haspopup'
+        | 'aria-expanded'
+        | 'aria-activedescendant'
+        | 'onClick'
+        | 'onKeyDown'
+        | 'disabled'
+    >;
+
 export type SelectRenderControlProps = {
     onClear: () => void;
+    /** @deprecated use triggerProps instead */
     onClick: (e: React.MouseEvent<HTMLElement>) => void;
+    /** @deprecated use triggerProps instead */
     onKeyDown?: (e: React.KeyboardEvent<HTMLElement>) => void;
-    renderClear?: (args: SelectRenderClearArgs) => React.ReactNode;
-    renderCounter?: () => React.ReactNode;
+    renderClear: (args: SelectRenderClearArgs) => React.ReactNode;
+    renderCounter: () => React.ReactNode;
     ref: React.Ref<HTMLElement>;
     open: boolean;
+    /** @deprecated use triggerProps instead */
     popupId: string;
+    /** @deprecated use triggerProps instead */
     selectId: string;
+    /** @deprecated use triggerProps instead */
     activeIndex?: number;
     disabled?: boolean;
+    triggerProps: SelectRenderTriggerProps;
 };
+
 export type SelectRenderControlOptions = {
     value: SelectProps['value'];
 };
@@ -51,6 +73,28 @@ export type SelectRenderPopup = (popupItems: {
     renderList: () => React.JSX.Element;
 }) => React.ReactElement;
 
+export type SelectFilterInputProps = {value: string} & Pick<
+    React.InputHTMLAttributes<HTMLInputElement>,
+    | 'placeholder'
+    | 'onKeyDown'
+    | 'onChange'
+    | 'size'
+    | 'aria-label'
+    | 'aria-controls'
+    | 'aria-activedescendant'
+>;
+export type SelectRenderFilter = (props: {
+    /** @deprecated use inputProps instead */
+    onChange: (filter: string) => void;
+    /** @deprecated use inputProps instead */
+    onKeyDown: (e: React.KeyboardEvent<HTMLElement>) => void;
+    /** @deprecated use inputProps instead */
+    value: string;
+    ref: React.Ref<HTMLInputElement>;
+    style: React.CSSProperties;
+    inputProps: SelectFilterInputProps;
+}) => React.ReactElement;
+
 export type SelectSize = InputControlSize;
 
 export type SelectRenderCounter = (
@@ -62,13 +106,7 @@ export type SelectProps<T = any> = QAProps &
     UseOpenProps & {
         onUpdate?: (value: string[]) => void;
         renderControl?: SelectRenderControl;
-        renderFilter?: (props: {
-            onChange: (filter: string) => void;
-            onKeyDown: (e: React.KeyboardEvent<HTMLElement>) => void;
-            value: string;
-            ref: React.Ref<HTMLInputElement>;
-            style: React.CSSProperties;
-        }) => React.ReactElement;
+        renderFilter?: SelectRenderFilter;
         renderOption?: SelectRenderOption<T>;
         renderOptionGroup?: SelectRenderOptionGroup<T>;
         renderSelectedOption?: (option: SelectOption<T>, index: number) => React.ReactElement;