fix(Table): not propagate click in table actions menu #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
Raubzeug
approved these changes
Sep 13, 2024
lunaticenslaved
force-pushed
the
lunaticenslaved/fix-disabled-menu-item-click-propagation-in-table-actions
branch
from
ba98496 to
689cf68
Compare
lunaticenslaved
deleted the
lunaticenslaved/fix-disabled-menu-item-click-propagation-in-table-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1753
It's stopped here if an action is active
uikit/src/components/Table/hoc/withTableActions/withTableActions.tsx
Line 141 in ba98496
but if an action is disabled then the handler with
stopPropagationis not called.Maybe this is an appropriate way to fix this.