render buildings with historic=castle as major

[matkoniecz]

Currently, after b4aff69 only buildings with amenity=place_of_worship are considered major. I propose to add also buildings with historic=castle as important tourism attractions and landmarks.

[Circeus]

I'm curious... What is the display difference between regular and major buildings?

[nebulon42]

http://www.openstreetmap.org/#map=19/48.22735/16.35799

[Circeus]

So you mean that particular display style is linked to that aspect and not specifically to amenity=place_of_worship? I wouldn't have suspected (heck, I didn't know there was such a thing as "major buildings" in the style!).

[nebulon42]

There wasn't until recently AFAIK (see #565 and #1153). The rendering is specific to amenity=place_of_worship but the question is apparently if this should be extended to other types of buildings as well. See also the discussion on the mailing list.

[matkoniecz]

There is a problem - according to http://wiki.openstreetmap.org/wiki/Tag:historic%3Dcastle "draw a way around the outline of the construction.".

@pnorman
Is there a way to query whatever object is inside area tagged with historic=castle - without making it too inefficient?

[pnorman]

When I initially rewrote the buildings, I wanted to take out the special handling of buildings that had an amenity=place_of_worship tag because it didn't work well with churches that weren't P.O.W.s, churches as nodes inside buildings, and anything other than the simplest amenity=place_of_worship building=*.

We should probably decide on the above before looking at how to handle historic=castle, which is, if anything, even more complicated because the POI polygon contains the building polygon, not the other way.

[Wuzzy2]

Yes, please render castles, these are major landmarks.

[kocio-pl]

I think this is bad idea, so I will close it now. Icons should be much better and clear: #3099.

[dieterdreist]

I liked the idea of having castles rendered as special buildings (this is regardless of icons).

[kocio-pl]

I guess the icon and dark brown would be too much emphasis.

[dieterdreist]

2018-03-26 18:58 GMT+02:00 kocio-pl <notifications@github.com>:

I guess the icon and dark brown would be too much emphasis.

I'd say it may depend, but often city gates are significant tourist attractions, see for example: https://en.wikipedia.org/wiki/Porta_Nigra https://en.wikipedia.org/wiki/Porta_Maggiore https://en.wikipedia.org/wiki/Porta_San_Sebastiano https://commons.wikimedia.org/wiki/File:Speyer_BW_5.JPG https://fr.wikipedia.org/wiki/Porte_des_Allemands etc.

[kocio-pl]

I'm not sure if I understand you properly, but for city gates we have separate ticket (#152) and defensive towers are rendered now, so such popular objects would be visible anyway.

[dieterdreist]

sorry, mixed tickets