Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render landuse=aquaculture #1774

Open
Penegal opened this issue Aug 21, 2015 · 53 comments
Open

render landuse=aquaculture #1774

Penegal opened this issue Aug 21, 2015 · 53 comments
Assignees
Milestone

Comments

@Penegal
Copy link
Contributor

Penegal commented Aug 21, 2015

Hello, dear CartoCSSers.

I just noticed landuse=aquaculture isn't rendered. I don't know for other countries, but, here in France, this is a common land use along the coasts, usually tens of hectares lots; mainly oyster beds, but we are not the only ones who have this kind of farming, for oysters or other species, and it can be a useful feature of the seascape to guide oneself on the tidal flats, or simply to avoid damaging them by piloting one's boat on them. Should be good to render it. A suggestion for the rendering: using a striped zone with a deepest blue than the one used for the sea?

Hoping this is relevant,

Regards.

@polarbearing
Copy link
Contributor

6.8K uses, and wiki started 2012.

Can you point to good examples? Can we assume that there is some water feature mapped as well?

@Penegal
Copy link
Contributor Author

Penegal commented Aug 21, 2015

Well, there's this one or that one, and you can find here an untagged example, to see the space such landuse can... well, use. There is a question upon these on the help, and I requested some additional examples.

@matkoniecz matkoniecz changed the title Landuse=aquaculture not mapped render landuse=aquaculture Aug 22, 2015
@matkoniecz matkoniecz added this to the New features milestone Aug 22, 2015
@matkoniecz
Copy link
Contributor

Probably rendering should happen in layer used by forest symbols to keep it visible in lakes.

@kocio-pl
Copy link
Collaborator

Maybe some simple shells pattern should be used here?

@polarbearing
Copy link
Contributor

Pattern yes, the question is which. Aquaculture could also be salmon in the sea and freshwater fish in ponds. Maybe a fish icon is more generic. The 'fishmonger' would also sell shells.

@kocio-pl
Copy link
Collaborator

We already use fish icon for fishmonger shops, but it would probably be just the outline and not in violet, so it's also the shape available to use here.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 6, 2015

Set of propositions on z14 using current seafood icon with black, 10% gray and marina-text with or without background (quarry color):
aquaculture-black-14
aquaculture-black-nofill-14
aquaculture-gray10-14
aquaculture-gray10-nofill-14
aquaculture-marina-14
aquaculture-marina-nofill-14

@HolgerJeromin
Copy link
Contributor

Imo most of them are too heavy. The variant with the border and the icon is nice. Could you try something between the fourth and last fish color?

@polarbearing
Copy link
Contributor

Thanks. The first one looks like a piranha army invading :-) . There should be no special background since it is no different kind of water. A blue lighter than the sea could be used for the fish, I think that is what Holger means, and a blue slightly darker than the sea for the boundary.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 6, 2015

Icons with water-text color (border gray and water-text):
aquaculture-water-gray-14
aquaculture-water-water-14

@polarbearing
Copy link
Contributor

Border in water-text colour is good now. Fish is still quite heavy, I'd prefer the subtlety trees have in the forest. Could we have just the outline of the fish?

The feature should have very little prominence, it's just the crop from some type of farming, comparable with an orchard in feature importance.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 6, 2015

The same water-text border, icon with halfway color between water and white:
aquaculture-dae7e7-14

@polarbearing
Copy link
Contributor

Good progress from my perspective, let's wait for some more opinions from the daytime folks.

@imagico
Copy link
Collaborator

imagico commented Sep 7, 2015

I am not sure if the fish symbol is ideal here - It could equally indicate a fish catching area, incidentally this is probably a much more common application of a fish symbol pattern in maps.

I have no specific suggestion for a better pattern but something clearly indicating a fixed installation would be important. Since mollusc farms are frequently in tidal areas it would also be important for it to work well in combination with wetland=tidalflat.

@Penegal
Copy link
Contributor Author

Penegal commented Sep 7, 2015

I agree with @imagico: even if I have no better idea, that seems to indicate a fishing area, or something limited to fishes, even for mollusc farms. Besides, as this landuse is somewhat mixed, because it doesn't necessarily ban other uses of the area such as swimming or sailing, maybe a dashed limit could be better.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 7, 2015

The feature should have very little prominence, it's just the crop from some type of farming, comparable with an orchard in feature importance.

Let's try something abstract like "underwater orchard" - icon with the same color (green could be good for algae):
aquaculture-dot-orchardgreen-14

icon with a color halfway between water and white (subtle):
aquaculture-dot-dae7e7-14

white dot (more contrast then above):
aquaculture-dot-white-14

black dot (as in "general"):
aquaculture-dot-black-14

water-text dot (as the boundary line - like "some water-related things"):
aquaculture-dot-6699cc-14

@polarbearing
Copy link
Contributor

So if people don't like fishes, the orchard dots are a good idea. The last one, water-text dot colour, works best for me.

@HolgerJeromin
Copy link
Contributor

I do not recognise the first image as green, but i like it anyway. Could live with the last, too.
It is very dependent of the monitor (settings), second image pattern is not visible here.

@Penegal
Copy link
Contributor Author

Penegal commented Sep 7, 2015

I agree with @polarbearing : the last one is the best proposal IMHO.

Edit/OT : being French, I like the orchard-like idea, as, in French, seafood literally translates to sea fruits; that makes sense to me. 😄

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 7, 2015

@Penegal Yeah, in polish it's the same ("owoce morza") 😉 , however the idea came to me right from the @polarbearing notes.

@mboeringa
Copy link

+1 for the last proposal.

@meased
Copy link
Contributor

meased commented Sep 9, 2015

I have used this tag in the northwest US to map salmon hatchery grounds that are not over water. I wonder how this would look in that context. Any rendering at all would be awesome though.

Example here.

@HolgerJeromin
Copy link
Contributor

The salmon hatchery ground felt wrong at first, but the wiki states "Area on land or sea, where fish, shellfish, or shells are breed". So this should look ok on land, too.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 9, 2015

I was thinking a bit what does "Area on land or sea" mean and I'm not sure if it's also land devices or just water ponds on the land (as opposed to the open sea). What do you think?

@polarbearing
Copy link
Contributor

https://www.openstreetmap.org/way/369021245 seems what @meased means.

My preferred interpretation would also give the aqua tag only to the water features and keep the site as landuse=farmyard or =commercial.

@meased
Copy link
Contributor

meased commented Sep 9, 2015

My preferred interpretation would also give the aqua tag only to the water features and keep the site as landuse=farmyard or =commercial.

@polarbearing: I like your interpretation better than mine.

@matthijsmelissen
Copy link
Collaborator

@malcolmh Am I right that you are the person behind OpenSeaMap?

We have some problems finding a good representation for landuse=aquaculture for the default openstreetmap rendering. Do you have any suggestions? Do you know how aquaculture is displayed on other (maybe paper) maps?

@malcolmh
Copy link

The international standard for marine maps is: http://www.iho.int/iho_pubs/standard/S-4/INT1_FR_Ed5_2012.pdf
Sections K.44 - K.48 illustrate the symbols used for the various types of aquaculture.

@polarbearing
Copy link
Contributor

Ok, so basically a thin outline of either a fish or a shell, and a dotted or dashed border for haven vs. culture.

And the fish swimming left to right.

@dieterdreist
Copy link

sent from a phone

Am 17.09.2015 um 00:32 schrieb Malcolm Herring notifications@github.com:

The international standard for marine maps is: http://www.iho.int/iho_pubs/standard/S-4/INT1_FR_Ed5_2012.pdf
Sections K.44 - K.48 illustrate the symbols used for the various types of aquaculture.

could we use these from a legal point of view? The document states at the bottom of the page "all rights reserved"

@matthijsmelissen
Copy link
Collaborator

I think if we don't copy them literally, but use the same concepts (e.g. a brown dashed line with a shell in it) we should be fine.

@malcolmh
Copy link

On 17 Sep 2015, at 08:12, dieterdreist notifications@github.com wrote:

could we use these from a legal point of view? The document states at the bottom of the page "all rights reserved"

The document itself is copyright, but the information within is intended for unrestricted use - the whole point of a standard.

@imagico
Copy link
Collaborator

imagico commented Sep 17, 2015

Please keep in mind this document outlines ideas for printed marine maps. Those have very special properties, in particular they are not designed for a general audience but for readers with very specific qualifications and expectations. This style is not a marine map and violates some of the most basic principles of those and is not a printed map either so concepts from marine maps will not necessarily work well here.

Note there are some interesting concepts shown there, in particular the 'outline with symbols interleaved' technique. In general most of the ideas there will however only work on very specific scales, for marine farms they have three suggestions for example:

  • single icon (two different versions)
  • outline with single icon in the middle
  • outline with symbols interleaved

Each of these is clearly intended and will only work well on a specific scale.

@dieterdreist
Copy link

sent from a phone

Am 17.09.2015 um 09:24 schrieb Malcolm Herring notifications@github.com:

The document itself is copyright, but the information within is intended for unrestricted use - the whole point of a standard.

just because it's a standard doesn't automatically mean you can use it for free (could require you to pay licensing fees for instance)

@imagico
Copy link
Collaborator

imagico commented Dec 7, 2015

Just a remark since this came up in #1990 - both the pictorial and the abstract pattern idea have potential here i think - you would have to rethink the outline though and avoid the fishing association (for example by combining fish and mollusc symbols).

@kocio-pl kocio-pl self-assigned this Sep 19, 2017
@kocio-pl
Copy link
Collaborator

I'm not sure that we can find a proper solution and this might be not too important on general map. This ticket can be reopened if there are some ideas how to do it, of course.

@SomeoneElseOSM
Copy link
Contributor

As an example of what rendering these look like, have a look at e.g. http://map.atownsend.org.uk/maps/map/map.html#zoom=13&lat=53.2496&lon=-9.7291 . That's just using the "landuse=commercial" colour from z12, but gives an idea of how much features like this "crowd other features out".

As an aside re tagging, in the UK and Ireland there's also some use of fish_farm and fishfarm for presumably the same features, and "aquaculture" is also used for inland fisheries too.

@kocio-pl
Copy link
Collaborator

Thanks for your hints! 👍 It's good to compare with something which is already used elsewhere.

This idea is smart (even if I would rather use "industrial" color), but I don't like the rendering, because it's too strong and doesn't look like a water any more.

@Adamant36
Copy link
Contributor

@kocio-pl, any chance of revisiting this now that there is a pattern creation tool and its usage has increased to 23,000? Maybe @jeisenbe can come up with something workable. If nothing else, it could just have an outline, since its like a protected area, or the names could just be rendered.
taghistory 7

@matkoniecz
Copy link
Contributor

Rendering just name will encourage tagging for renderer.

I think that it is not at all like protected area (rather opposite).

@Adamant36
Copy link
Contributor

@matkoniecz, I guess your right on it not being a protected area. I originally found the tag by look for how to tag fish hatcheries and that was what came up. I think government fish hatcheries would be protected areas. I wouldn't be surprised if people were tagging them with this tag either. Since there doesn't seem to be an alternative. Either way, even if its not a protected area that doesn't mean it couldn't be rendered with an outline.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 23, 2018 via email

@kocio-pl
Copy link
Collaborator

The discussion is back, so I reopen the ticket, however I still have no clear idea and can just follow your choice.

@kocio-pl kocio-pl reopened this Nov 23, 2018
@polarbearing
Copy link
Contributor

The test renderings from 2015 were all focusing on sea-based mapping. Could we dig for how many are mapped on land with ponds and how many on sea?

An outline alone might not be self-explanatory, thus a pattern or an icon would be required.

@oinag
Copy link

oinag commented Jan 19, 2020

Is this still active? I think that this render should not only include the fish or shell, but icons of all types of aquaculture in the Wiki (fish, oyster, shrimp, mussels).

@jeisenbe
Copy link
Collaborator

@oinag - would you be interested in designing this?

@oinag
Copy link

oinag commented Jan 19, 2020

@jeisenbe Yes, although I do not have experience with contributing to Carto. I expect that there is a guide on how these specific patterns work, right?

@imagico
Copy link
Collaborator

imagico commented Jan 19, 2020

There is no specific guideline for pattern design in OSM-Carto. Some general tips:

  • patterns should be weaker in appearance than individual point symbol or other signatures in the map.
  • patterns need to be periodic and in a size that is a fraction of the metatile size (i.e. a power of two).
  • patterns should be designed as SVG files although a mapnik bug requires us to use a PNG version for accurate rendering.
  • most patterns are designed based on the appearance of the area in question in direct view instead of indirect depiction of products derived from it like crops. This is not a fixed principle though.
  • patterns should if possible be designed in a way that they are intuitively recognizable.
  • patterns should not be misleading or encourage abuse of a tag for a different purpose.
  • patterns should be designed in a way that their symbols are not mistaken for individual mapped features.
  • useful tool for creating patterns is here: http://www.imagico.de/map/jsdotpattern.php

@oinag
Copy link

oinag commented Jan 19, 2020

@imagico Thank you, I will see what I can do, however I think using the symbols for the products (fish, shrimps...) will be necessary. As you said, patterns should be easily recognizable

@RedAuburn
Copy link
Contributor

It'd be good to have this implemented, currently landuse=aquaculture is used 61,425 times.

I think rendering as opaque white with an outline similar to leisure=nature_reserve (with the gradated inside) could be good. Also rendering a name. Something like this:
Screenshot 2022-09-13 at 14 02 26
location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests