Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining diacritics rendering wrong in various languages #2017

Closed
claysmalley opened this issue Jan 6, 2016 · 10 comments
Closed

Combining diacritics rendering wrong in various languages #2017

claysmalley opened this issue Jan 6, 2016 · 10 comments

Comments

@claysmalley
Copy link

Many South Asian alphabets have combining characters that appear to the left of the character they "attach" to. These seem to be rendering on the wrong side of the combining character in various languages. Some other marks are rendering too high, too low, or not at all. It looks hella clowny, and unreadable in some cases, to native readers of these languages.

English Native Script Mapnik
Mandalay Myo Burmese: မန္တလေးမြို့ selection_264
Manikganj Bengali: মানিকগঞ্জ selection_268
Birtamod Devanagari: बिर्तामोड selection_269
Changwat Surin Thai: จังหวัดสุรินทร์ selection_272 (last mark is too high)
Shigatse Tibetan: གཞིས་ཀ་རྩེ selection_271 (also bad spacing)
Gondar Ethiopic: ጎንደር selection_270 (no combining diacritics, just bad spacing)
@gravitystorm
Copy link
Owner

There are many font rendering problems currently showing on the openstreetmap.org tileserver, since it is running an older version of the mapnik rendering library. Most will be fixed when the server admins upgrade to mapnik 3, which will hopefully happen soon.

Can you check your examples against the opencyclemap and/or transport layers please? Both of these are using a similar list of fonts to openstreetmap-carto, but have already been upgraded to mapnik 3.

@claysmalley
Copy link
Author

Just checked. Transport Map and Cycle Map look great! Ethiopic text still has the weird spacing issue but complex text layout is working just fine.

@matkoniecz matkoniecz added this to the 3.x - Needs upgrade to Mapnik milestone Jan 6, 2016
@pnorman
Copy link
Collaborator

pnorman commented Jan 6, 2016

It's not needed in this case, but in general it's best to include an image of the correct rendering, since otherwise we're depending on our browser to render the text correctly.

@qeith
Copy link

qeith commented Jan 15, 2016

I can confirm that Tibetan and Devanagari are rendering far better in the cycle and transport layers. Both had the correct order/orientation for the places I checked, and only some spacing issues remained. For Tibetan these spacing issues are far less than they are at present in the default layer's rendering.

@pnorman
Copy link
Collaborator

pnorman commented May 18, 2016

Burmese, Bengali and Devanagari are all confirmed fixed with Mapnik 3. I'll review the others when done with some pre-rendering.

@pnorman
Copy link
Collaborator

pnorman commented May 18, 2016

Most of these are fixed in Mapnik 3.

If there are still problems, please open a new ticket for the issue. It's possible some of the fonts might need changing. Include links to the problem area, a picture of the correct rendering of the text, and a picture of the rendering of the area. tile.osm.org doesn't use Mapnik 3, so you can't use it for this.

@pnorman pnorman closed this as completed May 18, 2016
@matthijsmelissen
Copy link
Collaborator

@claysmalley Mapnik 3 has now been rolled out. Could you have a look whether this has improved now? If now, could you provide a link to the map location where you find bad rendering (some tiles might not have been refreshed since the upgrade)?

@claysmalley
Copy link
Author

Burmese: ✔️ renders properly. Note: if you find any broken Burmese text, it's likely that it was typed up in the wrong encoding (Zawgyi instead of Unicode)
Bengali: ✔️ renders properly
Devanagari: ✔️ renders properly
Thai: ⚠️ renders properly, though the font for city labels is monospace
Lao: ✔️ renders properly
Tibetan: ⚠️ renders properly, although font is small and hard to read
Ethiopic: ✔️ renders properly
Sinhala: ❌ totally broken; could probably be fixed just by using a better font

I'll open a new ticket for each of the issues here

@claysmalley
Copy link
Author

#2336, #2337, #2338

@matthijsmelissen
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants