Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor waterway halo/casing too strong #4485

Open
BengbuGuards opened this issue Oct 13, 2021 · 3 comments
Open

Minor waterway halo/casing too strong #4485

BengbuGuards opened this issue Oct 13, 2021 · 3 comments

Comments

@BengbuGuards
Copy link

Expected behavior

Tree signs do not cover rivers, streams and gullies do not show white strokes.

Actual behavior

There is a bug regarding the waterway rendering, when using waterway=stream, ditch, drain , a white stroke appears when it passes through a background fill area (e.g. forest) and the top fill of the forest (trees) covers the waterway when it passes through the forest.

Links and screenshots illustrating the problem

Screenshot

@imagico
Copy link
Collaborator

imagico commented Oct 13, 2021

Duplicate of #3883 as far as the symbols over water features is concerned. Not sure about your exact complaint about the white casing of minor waterways - do you dislike that we have it at all, do you dislike its strength or do you dislike it only in combination with the forest symbols?

@BengbuGuards
Copy link
Author

Duplicate of #3883 as far as the symbols over water features is concerned. Not sure about your exact complaint about the white casing of minor waterways - do you dislike that we have it at all, do you dislike its strength or do you dislike it only in combination with the forest symbols?

I'm afraid they all are. The white strokes on the small waterways are not only incongruous with the larger waterways, they can also have a blurred look. As for the tree markings, a possible solution would be to have the waterways rendered in order after the trees.

@imagico
Copy link
Collaborator

imagico commented Oct 15, 2021

The bright halo/casing of minor waterways has existed for a long time to ensure decent readability on very different backgrounds especially at the lower zoom levels. See #1781, #2098. IMO the casing is too strong but its presence it fairly unavoidable with our current color scheme. #4128 can help with that but does not remove the need for a bright casing. In the ac-style i show a more muted casing:

https://imagico.de/map/pict/ac_samples/caucasus_z15.png
https://www.openstreetmap.org/#map=15/43.6372/40.6883

Discussion on the landcover symbol layering should go to #3883, changing the title of this issue to reflect the more limited scope.

@imagico imagico changed the title Waterway rendering bug Minor waterway halo/casing too strong Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants