-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
landuse=basin with basin=detention #709
Comments
basin key is currently not in the dabase (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style ), so it is unlikely to be done in near future. |
Looking at a couple semi randomly selected |
Under
As it is right now, all |
So feel free to propose a pull request :) Sorry for the delay, but we have hundreds of things that are all "easy fixes"... |
Thanks for the reply! I've actually been working on that since last night. The code seems straightforward enough but I'm having a hell of a time following the vague, prior-knowledge-required installation instructions. It'd be really nice if someone could help me get this thing up and running so I can test what I'm doing. |
http://switch2osm.org/loading-osm-data/ for loading the data. For tilemill, https://hackpad.com/TileMill-I6rxRVszKMv is as far as I got |
@claysmalley See also #657 (comment) |
@claysmalley Note also that basin key is currently not in the dabase (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style ), so merging implementation for this requires reloading entire database. |
If that is still something that should be fixed - is anybody aware about OSM elements that would be a good examples of situation? |
According to the wiki definition and since #3104, we can render the subtag basin as intermittent water body as figured in the first post. |
@jragusa Can you provide any example of OSM element (way/relation)? |
Initially, I thought it was only related to storm events and hence to some countries (U.S.) but actually we also find this feature in Europe. They are built to store water during important rainfall and hence prevent large river flooding. They are also frequently found along major highways. An example here near Annecy (https://www.openstreetmap.org/#map=18/45.92946/6.12063) where you can find 2 basins with the correct tags (https://www.openstreetmap.org/way/529090226 and https://www.openstreetmap.org/way/529090223). Look at the aerial photograph to compare: https://www.geoportail.gouv.fr/carte?c=6.121392731642797,45.929393524870136&z=18&l0=ORTHOIMAGERY.ORTHOPHOTOS::GEOPORTAIL:OGC:WMTS(1)&l1=GEOGRAPHICALGRIDSYSTEMS.MAPS::GEOPORTAIL:OGC:WMTS(0)&permalink=yes The upper one contains some water while the lower one is empty |
@matkoniecz |
@matkoniecz and @kocio-pl Are you agree to apply intermittent water body pattern to the |
Reading Wikipedia articles and short description on OSM wiki I understand that basin=retention is called wet pond, because it does not loose water, so I would leave it as it is. But |
As in http://wiki.openstreetmap.org/wiki/Tag:landuse%3Dbasin landuse=basin + basin=detention should be used for tagging of dry basins for stormwater.
Proposal for rendering:
The text was updated successfully, but these errors were encountered: