Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Align Magento Driver Models to Platform GraphQL Schema Types #1298

Open
griest024 opened this issue Feb 18, 2021 · 1 comment
Open
Assignees
Labels
feat a new feature, enhancement, or improvement p2 medium priority
Milestone

Comments

@griest024
Copy link
Member

💡 Feature request

Feature Name

Align Driver Models to Platform GraphQL Schema Types

The Desired Behavior

I want typescript models interface types to exactly match the types in the GraphQL schema.

Your Use Case

As a maintainer, I would like to rely on TS types to inform my null-checking decisions in the client-side code.

Prior Work

Magento love to pass null for array types; we should indicate this with optional types in our interfaces.

@griest024 griest024 added the feat a new feature, enhancement, or improvement label Feb 18, 2021
@damienwebdev damienwebdev changed the title [FEAT] Align Driver Models to Platform GraphQL Schema Types [FEAT] Align Magento Driver Models to Platform GraphQL Schema Types Jan 2, 2022
@AnnieMi888 AnnieMi888 added this to the Daffodil v1.0 milestone Dec 19, 2023
@AnnieMi888 AnnieMi888 added the p2 medium priority label Dec 19, 2023
@griest024
Copy link
Member Author

blocked by #3137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement p2 medium priority
Projects
None yet
Development

No branches or pull requests

3 participants