Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The main mobile sidebar for daff.io shows the docs sidebar instead of the main nav info #2676

Closed
Tracked by #1925
xelaint opened this issue Dec 20, 2023 · 2 comments · Fixed by #2686
Closed
Tracked by #1925
Assignees
Labels
bug A confirmed bug report docs This issue is related to documentation p1 critical priority package: daff.io @daffodil/daff.io
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Dec 20, 2023

🐛 Bug report

Current Behavior

The main mobile sidebar for daff.io shows the docs sidebar instead of the main nav info

Expected Behavior

The mobile sidebar for daff.io should show the primary nav information instead of the docs sidebar with all the packages. That should be a sidebar that's only shown when navigated to the docs page.

Relates to: #1925

Minimal reproduction of the problem with instructions

  1. Visit next.daff.io
  2. Switch to mobile view
  3. Click on the hamburger menu

What is the motivation / use case for changing the behavior?

We should show the correct information.

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added bug A confirmed bug report package: daff.io @daffodil/daff.io labels Dec 20, 2023
@xelaint xelaint added this to the Daffodil v1.0 milestone Dec 20, 2023
@AnnieMi888 AnnieMi888 added p1 critical priority docs This issue is related to documentation labels Dec 20, 2023
@AnnieMi888
Copy link

relates to #1925

@graycoreio graycoreio deleted a comment from AnnieMi888 Dec 20, 2023
@damienwebdev
Copy link
Member

Depends on #2680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed bug report docs This issue is related to documentation p1 critical priority package: daff.io @daffodil/daff.io
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants