Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nginx): add support for nginx v1.19 #18

Merged
merged 9 commits into from
Feb 10, 2021
Merged

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, the hostname and various other behaviors are hardcoded into the container and Nginx configuration. Additionally, there's no 1.19 support.

Fixes: N/A

What is the new behavior?

This adds support for simple environment variables to configure minor details of the nginx configuration and provides an nginx v1.19 image.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

I've dropped support for the v1.17 container. The v1.18 container (and v1.19) are backward compatible, simply update to the new versions.

Other information

@damienwebdev damienwebdev merged commit 3ec7152 into master Feb 10, 2021
@damienwebdev damienwebdev deleted the new_nginx_with_env branch February 10, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant