Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Project Dolphin - Magento 2 Github Codespaces #64

Merged
merged 13 commits into from
Aug 4, 2022

Conversation

MateusDadalto
Copy link
Contributor

@MateusDadalto MateusDadalto commented Aug 4, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

See #42

Fixes: #42

What is the new behavior?

See #42 #39

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGES

This is currently non-breaking, but will become breaking in the future. Devs are encouraged to start using the Dolphin environment.

damienwebdev and others added 12 commits August 4, 2022 14:18
Co-authored-by: Mateus Dutra Dadalto <mateusdadalto@gmail.com>
Co-authored-by: Mateus Dutra Dadalto <mateusdadalto@gmail.com>
BREAKING CHANGES: the base image for most environments has changed from
alpine-develop to dolphin, which is still alpine based. Most thing
should work the same, but this could be breaking for you.

Co-authored-by: Mateus Dutra Dadalto <mateusdadalto@gmail.com>
Co-authored-by: Nolan Arnold <44958241+Nolan-Arnold@users.noreply.github.com>
Co-authored-by: Nolan Arnold <44958241+Nolan-Arnold@users.noreply.github.com>
Co-authored-by: Mateus Dutra Dadalto <mateusdadalto@gmail.com>
Co-authored-by: Mateus Dutra Dadalto <mateusdadalto@gmail.com>
@damienwebdev damienwebdev marked this pull request as ready for review August 4, 2022 18:31
@damienwebdev damienwebdev self-requested a review as a code owner August 4, 2022 18:31
@damienwebdev damienwebdev changed the title Dolphin feat: Project Dolphin - Magento 2 Github Codespaces Aug 4, 2022
@damienwebdev damienwebdev merged commit 7e66c42 into master Aug 4, 2022
@damienwebdev damienwebdev deleted the dolphin-rebased branch August 4, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Devcontainers Support in VSCode (Dolphin)
2 participants