fix: wrong di.xml configuration - missing noNamespaceSchemaLocation #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd xmlns:xsi This caused static tests for M2 fail and when project is using automated testing for the modules it is inconvenient to exclude this module only. By this change, static tests will pass for this module. Example how I run tests: - `php -d memory_limit=-1 ../../../../code/vendor/bin/phpunit -c phpunit.xml --testsuite "Code Integrity Tests" --filter "SchemaTest"` Output from the command without this change: ``` PHPUnit 9.5.22 #StandWithUkraine There was 1 failure: 1) Magento\Test\Integrity\Xml\SchemaTest::testXmlFiles Passed: 2980, Failed: 1, Incomplete: 0, Skipped: 0. Data set: /vendor/graycore/magento2-cors/etc/di.xml The XML file at /app/vendor/graycore/magento2-cors/etc/di.xml does not have a schema properly defined. It should have a xsi:noNamespaceSchemaLocation attribute defined with a URN path. E.g. xsi:noNamespaceSchemaLocation="urn:magento:framework:Relative_Path/something.xsd" Failed asserting that actual size 0 matches expected size 2. /app/dev/tests/static/testsuite/Magento/Test/Integrity/Xml/SchemaTest.php:30 /app/vendor/magento/framework/App/Utility/AggregateInvoker.php:57 /app/dev/tests/static/testsuite/Magento/Test/Integrity/Xml/SchemaTest.php:16 /app/vendor/magento/framework/App/Utility/AggregateInvoker.php:116 /app/vendor/magento/framework/App/Utility/AggregateInvoker.php:71 /app/dev/tests/static/testsuite/Magento/Test/Integrity/Xml/SchemaTest.php:16 FAILURES! Tests: 1, Assertions: 8943, Failures: 1. ``` Desired output (with this change): ``` PHPUnit 9.5.22 #StandWithUkraine . Time: 00:05.666, Memory: 24.00 MB OK (1 test, 8943 assertions) ```
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: wrong di.xml configuration - missing noNamespaceSchemaLocation and xmlns:xsi
This caused static tests for M2 fail and when project is using automated testing for the modules it is inconvenient to exclude this module only. By this change, static tests will pass for this module.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
php -d memory_limit=-1 ../../../../code/vendor/bin/phpunit -c phpunit.xml --testsuite "Code Integrity Tests" --filter "SchemaTest"Output from the command without this change:
What is the new behavior?
Desired output (with this change):
Does this PR introduce a breaking change?
Other information