-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array of images #37
Comments
I've never really understood the array thing, so I may be off base here but maybe try setting {
"data": {
"mongodbHerokuD589Dff8Gat": {
"name": "Robe A",
"pics": [
{ # <--------------------------- nodeType: whatever type this thing is
"src": "H18/IMG_1613.jpg"
},
{
"src": "H18/IMG_1624.jpg"
}
]
}
}
} |
@wKovacs64 thanks for your suggestion! |
I also noticed this issue when upgrading gatsby-plugin-remote-images from version 1 to version 2. In my case, it worked fine in version 1, but on version 2 I'm seeing what you described. @ar7hur , I suspect that your example works fine when downgrading to the plugin version 1.0.7. Could you confirm that? |
@sometea it works perfectly with version 1.0.7 you are right! |
@ar7hur Is this a public project, by chance?
Did this error or just put |
@wKovacs64 unfortunately not (yet), I'm just starting to work on it! |
Sorry, I haven't had time to look into this further. @graysonhicks The changes in the original effort to temporarily future-proof the plugin (without fully converting to the new Gatsby schema customization approach) seem to have done more harm than good. What do you think about rolling them back and reverting to the old code? It will break at some point in the future, but at least every advertised feature works. We can continue fleshing out a full conversion (like #32 or a different angle) in the meantime, rather than trying to maintain this one-foot-in situation. Thoughts? |
Hm, yea I am okay with that. With #32, will we have this array of images bug still? It looks like main thing holding #32 back is the build times issue. @wKovacs64 |
OK, I'll try to throw a quick PR together later that rolls it back. You'll want to publish 2.1.1 or something to fix 2.x users.
The main issue with #32 currently is the build times, but so far, it seems to be a Gatsby design issue rather than anything specific to this plugin. So we either expect users to deal with it like @kilburn chose to do, or find an entirely different approach (which has yet to reveal itself). The array thing will morph. Instead of being able to augment an arbitrary |
Released with v2.2.0 |
I'm working with an array of image. With the following config, the plugin adds its
localImage
field at the root instead of for each element in thepics
array.My type looks like:
The text was updated successfully, but these errors were encountered: