Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Keyboard Height] Page is pushed outside of screen when opening the keyboard after rotation #807

Closed
lavikabel opened this issue May 30, 2022 · 2 comments

Comments

@lavikabel
Copy link

Hi,
First of all I must say that I love this plugin, you have done an amazing job and keep supporting it which makes it even more impressive, thanks man.

I have a problem with the calculation of the keyboard height on android.
If I load the page in portrait mode and then rotating to landscape opening the keyboard will push the page outside of screen.

I feel its a same issue as #729 but there its a full screen.

I tried to debug and I think its because mWindowVisibleDisplayFrameHeight is only calculate once (in init()) and not when changing orientation.

I added the calculation code from the init() in SetMargin() and the problem was solved.

Thanks

@KojiNakamaru
Copy link
Member

Thank you for your report. I tried to import your refinement but found some odd behaviour which is difficult to avoid, so I updated the code as in #809. Could you please check the latest binaries.

@lavikabel
Copy link
Author

Great its working!!
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants