Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Doc versus Rules list inside _config.sh #17

Closed
Silicoman opened this issue Apr 7, 2023 · 1 comment · Fixed by #18
Closed

Improve Doc versus Rules list inside _config.sh #17

Silicoman opened this issue Apr 7, 2023 · 1 comment · Fixed by #18
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@Silicoman
Copy link
Contributor

Hi,

We actually have a list rules to add eco-design tag.
RULES_KEYS=css:S4655,php:S2014,Web:ItemTagNotWithinContainerTagCheck
It will interesting to improve documentation about this list.
I was thinking about to making a markdown about this rules and parsing this markdown to got keys.

@dedece35
Copy link
Member

dedece35 commented Apr 9, 2023

Hi @Silicoman,
very good idea.

Actually, rules list in _config.sh file are only here for my tests.
For me, we have to do an audit of our existing rules and check if they are already present natively in SonarQube : check issue green-code-initiative/ecoCode#34

But I'm agree with you, if we can improve this system, no problem.

Thank you, sir !

PS : please think about install process for developers
PS2 : Warning, because there is a PR created during hackathon #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants