diff --git a/CHANGELOG.md b/CHANGELOG.md index 4d6548bc1..cf6f01553 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [171](https://github.com/green-code-initiative/ecoCode/issues/171) Add migration mechanism to support "issue re-keying" ### Changed +- [#161](https://github.com/green-code-initiative/ecoCode/pull/161) Remove unnecessary junit dependencies in pom.xml - [166](https://github.com/green-code-initiative/ecoCode/issues/166) Correction of wrong message of rule EC63 - [167](https://github.com/green-code-initiative/ecoCode/issues/167) Use same kind for rules across different languages diff --git a/java-plugin/pom.xml b/java-plugin/pom.xml index 6e5e11f38..88ba0c619 100644 --- a/java-plugin/pom.xml +++ b/java-plugin/pom.xml @@ -69,12 +69,6 @@ test - - org.junit.jupiter - junit-jupiter-migrationsupport - test - - org.assertj assertj-core diff --git a/javascript-plugin/pom.xml b/javascript-plugin/pom.xml index 8412187ea..379b9f388 100644 --- a/javascript-plugin/pom.xml +++ b/javascript-plugin/pom.xml @@ -38,11 +38,9 @@ sonar-analyzer-commons - - - junit - junit + org.junit.jupiter + junit-jupiter test diff --git a/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptPluginTest.java b/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptPluginTest.java index a558e0626..ad50f25ec 100644 --- a/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptPluginTest.java +++ b/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptPluginTest.java @@ -1,15 +1,15 @@ package fr.greencodeinitiative.javascript; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.sonar.api.*; import org.sonar.api.utils.Version; import static org.assertj.core.api.Assertions.assertThat; -public class JavaScriptPluginTest { +class JavaScriptPluginTest { @Test - public void extensions() { + void extensions() { Plugin.Context context = new Plugin.Context(new MockedSonarRuntime()); new JavaScriptPlugin().define(context); assertThat(context.getExtensions()).hasSize(1); diff --git a/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptRulesDefinitionTest.java b/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptRulesDefinitionTest.java index 60bdc8510..e90f75d95 100644 --- a/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptRulesDefinitionTest.java +++ b/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptRulesDefinitionTest.java @@ -1,14 +1,14 @@ package fr.greencodeinitiative.javascript; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.sonar.api.server.rule.RulesDefinition; import static org.assertj.core.api.Assertions.assertThat; -public class JavaScriptRulesDefinitionTest { +class JavaScriptRulesDefinitionTest { @Test - public void createExternalRepository() { + void createExternalRepository() { RulesDefinition.Context context = new RulesDefinition.Context(); new JavaScriptRulesDefinition().define(context); assertThat(context.repositories()).hasSize(1); diff --git a/php-plugin/pom.xml b/php-plugin/pom.xml index a79f181ef..0180065c8 100644 --- a/php-plugin/pom.xml +++ b/php-plugin/pom.xml @@ -40,18 +40,11 @@ - - junit - junit - test - - org.assertj assertj-core test - diff --git a/pom.xml b/pom.xml index 83d26a01e..c778ffec3 100644 --- a/pom.xml +++ b/pom.xml @@ -67,7 +67,6 @@ 1.21.0.505 true 3.4.1 - 4.13.2 5.9.1 3.23.1 @@ -156,13 +155,6 @@ test - - org.junit.jupiter - junit-jupiter-migrationsupport - ${junit.jupiter.version} - test - - org.assertj assertj-core @@ -170,13 +162,6 @@ test - - junit - junit - ${junit.version} - test - - org.sonarsource.python python-checks-testkit diff --git a/python-plugin/pom.xml b/python-plugin/pom.xml index bfef526ff..cbc4d6906 100644 --- a/python-plugin/pom.xml +++ b/python-plugin/pom.xml @@ -44,12 +44,6 @@ test - - junit - junit - test - -