Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel testing #439

Open
ribalba opened this issue Aug 29, 2023 · 4 comments · May be fixed by #651
Open

Add parallel testing #439

ribalba opened this issue Aug 29, 2023 · 4 comments · May be fixed by #651
Assignees

Comments

@ribalba
Copy link
Member

ribalba commented Aug 29, 2023

Currently the tests run for quite some time and there are some tests we could run in parallel. There is the great pytest-xdist package that uses workers to run tests in parallel. At some stage we should maybe look through all the tests and categorize them into two groups so we can seep up the ones that we can parallelize.

Very low prio though.

@ArneTR
Copy link
Member

ArneTR commented Aug 30, 2023

Is this still current, given your yesterday discovery that we start containers and use the reporters to derive data?

I see atm no way to parallelize this properly ... at least if you also want proper data output from the metric providers ...

@ribalba
Copy link
Member Author

ribalba commented Aug 31, 2023

There are also loads of tests that don't require the containers. All the schema/ parameter checking for example. We could have two categories of test and such speed up the testing. Really nothing we need right now but the tests running so long is quite annoying.

@ArneTR
Copy link
Member

ArneTR commented Sep 1, 2023

I will schedule it in for next week with Dan

@ArneTR
Copy link
Member

ArneTR commented Jan 4, 2024

Improvement done here: #637

Test time is now roughly 3 mins.

The onlything that actually takes up time is if the containers are started.

it would be technically possible to start the testing container with a different Id and thus effectively parallelize the tests.

Leaving this issue open for further inspection if tests balloon up again.

@dan-mm dan-mm linked a pull request Jan 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants