Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-tests hangs on Java 21 #10

Merged
merged 2 commits into from
Jun 18, 2024
Merged

tracing-tests hangs on Java 21 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2994963
fix Thread/sleep hangs on Java 19+
namenu Feb 12, 2024
93f8a12
[CI] add java-version dimesion to test matrix
namenu Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,25 @@ on:
- master
jobs:
build:
strategy:
matrix:
java-version: ["11", "17", "21"]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3.4.0
uses: actions/checkout@v4
- name: Setup Java
uses: actions/setup-java@v3.10.0
uses: actions/setup-java@v4
with:
java-version: '11'
java-version: ${{ matrix.java-version }}
distribution: 'corretto'
- name: Setup Clojure
uses: DeLaGuardo/setup-clojure@10.2
with:
cli: 1.11.1.1165

- name: Cache clojure dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.m2/repository
Expand Down
4 changes: 3 additions & 1 deletion test/com/walmartlabs/lacinia/tracing_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
[com.walmartlabs.lacinia.tracing :as tracing]
[com.walmartlabs.lacinia.schema :as schema]))

(set! *warn-on-reflection* true)

(def ^:private enable-timing (tracing/enable-tracing nil))

;; Used to convert nanos to millis
Expand All @@ -41,7 +43,7 @@
[_ _ value]
(let [resolved-value (resolve/resolve-promise)
f (fn []
(Thread/sleep (::delay value))
(Thread/sleep ^long (::delay value))
(resolve/deliver! resolved-value (::slow value)))
thread (Thread. ^Runnable f)]
(.start thread)
Expand Down
Loading