You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
Pressing Delete triggers the DELETE handler, which prints "DELETE Delete" to console; pressing Backspace triggers the BACKSPACE handler, which prints "BACKSPACE Backspace"
Actual behavior
Pressing either backspace or delete triggers the DELETE handler only, with "DELETE Backspace" printed for the backspace key and "DELETE Delete" printed for the delete key.
Platform (please complete the following information):
Version of react-hotkey: v2.0.0-pre4
Browser: Chrome 73
OS: macOS 10.14.3
Are you willing and able to create a PR request to fix this issue?
No -- I'm not familiar with the codebase
APPLICABLE TO v2.0.0-pre1 AND ABOVE: ======================
Include the smallest log that includes your issue:
Set logging to verbose (you'll need the development build if its possible):
import { configure } from 'react-hotkeys';
configure({
logLevel: 'verbose'
})
What Configuration options are you using?
None
configure({
//options
})
The text was updated successfully, but these errors were encountered:
Hey @nick-filigree, thanks for taking the time to point this out.
This was intentional and an attempt to be helpful so users of the library did not have to define key mappings for "Mac" Keyboards and "Windows" keyboards (the delete and backspace keys appearing in the same location, respectively). I see now that this was erroneous thinking, and that these keys should not be treated as aliases for one another.
In the next release, they will be treated as separate keys.
Describe the bug
Delete and Backspace are different keys, yet react-hotkeys appears to consider them one and the same.
How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc)
HotKeys
Repro case:
Expected behavior
Pressing Delete triggers the DELETE handler, which prints "DELETE Delete" to console; pressing Backspace triggers the BACKSPACE handler, which prints "BACKSPACE Backspace"
Actual behavior
Pressing either backspace or delete triggers the DELETE handler only, with "DELETE Backspace" printed for the backspace key and "DELETE Delete" printed for the delete key.
Platform (please complete the following information):
Are you willing and able to create a PR request to fix this issue?
No -- I'm not familiar with the codebase
APPLICABLE TO v2.0.0-pre1 AND ABOVE: ======================
Include the smallest log that includes your issue:
Set logging to verbose (you'll need the development build if its possible):
What Configuration options are you using?
None
The text was updated successfully, but these errors were encountered: